Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of Grpc and Rocksdb Please #1287

Closed
alidehghan opened this issue Dec 28, 2024 · 3 comments · Fixed by #1324
Closed

Example of Grpc and Rocksdb Please #1287

alidehghan opened this issue Dec 28, 2024 · 3 comments · Fixed by #1324
Assignees
@drmingdrmer

Comments

@alidehghan
Copy link

alidehghan commented Dec 28, 2024 •
edited
Loading

Could you please provide an example of grpc and rocksdb integrated? currently there are two separated rocksdb and grpc examples. It would be so nice if they are merged as new one.
@github-actions GitHub Actions
Copy link

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@alidehghan alidehghan changed the title Small Hint Please: Need include one example into my project as mod Example of Grpc and Rocksdb Please Dec 28, 2024
@drmingdrmer
Copy link
Member

Oh we've received multiple requests for this combination of features :)

To complete gRPC support, first we need to replace the concrete types Vote, LeaderId and LogId with traits. See:

@alidehghan
Copy link
Author

thanks for your kind response

@drmingdrmer drmingdrmer self-assigned this Feb 3, 2025
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Feb 3, 2025
@drmingdrmer
Refactor: example raft-kv-memstore-grpc
79f75e3 
Move protobuf types to 3 files:
- `app.proto` defines application API and types.
- `raft.proto` defines Raft-protocol API and types.
- `management.proto` defines non-app management API and types, such as
  membership config API.

- Part of databendlabs#1287
@drmingdrmer drmingdrmer mentioned this issue Feb 3, 2025
Merged
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Feb 3, 2025
@drmingdrmer
Refactor: example raft-kv-memstore-grpc
0cd75a3 
Move protobuf types to 3 files:
- `app.proto` defines application API and types.
- `raft.proto` defines Raft-protocol API and types.
- `management.proto` defines non-app management API and types, such as
  membership config API.

- Part of databendlabs#1287
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Feb 3, 2025
@drmingdrmer
Refactor: example raft-kv-memstore-grpc
5acd698 
Move protobuf types to 3 files:
- `app.proto` defines application API and types.
- `raft.proto` defines Raft-protocol API and types.
- `management.proto` defines non-app management API and types, such as
  membership config API.

- Part of databendlabs#1287
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Feb 3, 2025
@drmingdrmer
Refactor: example raft-kv-memstore-grpc
1561ffc 
Move protobuf types to 3 files:
- `app.proto` defines application API and types.
- `raft.proto` defines Raft-protocol API and types.
- `management.proto` defines non-app management API and types, such as
  membership config API.

- Part of databendlabs#1287
drmingdrmer added a commit that referenced this issue Feb 3, 2025
@drmingdrmer
Refactor: example raft-kv-memstore-grpc
1e883d7 
Move protobuf types to 3 files:
- `app.proto` defines application API and types.
- `raft.proto` defines Raft-protocol API and types.
- `management.proto` defines non-app management API and types, such as
  membership config API.

- Part of #1287
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Feb 4, 2025
@drmingdrmer
Doc: Finish gRPC example raft-kv-memstore-grpc
958c25a 
A rust test `tests/test_cluster.rs` brings up a 3 nodes cluster and
executes write and read on it.

- Fix: databendlabs#1287
@drmingdrmer drmingdrmer mentioned this issue Feb 4, 2025
Merged
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Feb 4, 2025
@drmingdrmer
Doc: Finish gRPC example raft-kv-memstore-grpc
c64caaf 
A rust test `tests/test_cluster.rs` brings up a 3 nodes cluster and
executes write and read on it.

- Fix: databendlabs#1287
drmingdrmer added a commit that referenced this issue Feb 4, 2025
@drmingdrmer
Doc: Finish gRPC example raft-kv-memstore-grpc
b3b0af0 
A rust test `tests/test_cluster.rs` brings up a 3 nodes cluster and
executes write and read on it.

- Fix: #1287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drmingdrmer drmingdrmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc: Finish gRPC example raft-kv-memstore-grpc drmingdrmer/openraft
2 participants
@drmingdrmer @alidehghan