Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -AppendServerInstance to Invoke-DbaWhoIsActive #9540

Open
ReeceGoding opened this issue Nov 5, 2024 · 1 comment
Open

Add -AppendServerInstance to Invoke-DbaWhoIsActive #9540

ReeceGoding opened this issue Nov 5, 2024 · 1 comment
Labels
feature triage required New issue that has not been reviewed by maintainers

Comments

@ReeceGoding
Copy link
Contributor

ReeceGoding commented Nov 5, 2024

Summarize Functionality

Invoke-DbaWhoIsActive calls Invoke-DbaQuery, but cannot be called with the -AppendServerInstance flag like Invoke-DbaQuery can. Let's fix that. When you call Invoke-DbaWhoIsActive on a bunch of servers at once, it pays to know which server you're seeing.

Is there a command that is similiar or close to what you are looking for?

Yes

Technical Details

This should be really easy, given that Invoke-DbaWhoIsActive calls Invoke-DbaQuery directly and already has a bunch of things built in for controlling what parameters go there.

@ReeceGoding ReeceGoding added feature triage required New issue that has not been reviewed by maintainers labels Nov 5, 2024
@ReeceGoding
Copy link
Contributor Author

Gave it a shot myself, but I've become confused by this line

$passedparams = $psboundparameters.Keys | Where-Object { 'Silent', 'SqlServer', 'SqlCredential', 'OutputAs', 'ServerInstance', 'SqlInstance', 'Database' -notcontains $_ }

Several of the parameters that are being filtered out aren't in Invoke-DbaWhoIsActive at all. Some where in this quite old version, so maybe the filter list is just very old?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature triage required New issue that has not been reviewed by maintainers
Projects
None yet
Development

No branches or pull requests

1 participant