Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some countries are missing #1

Open
lexman opened this issue Feb 29, 2016 · 8 comments
Open

Some countries are missing #1

lexman opened this issue Feb 29, 2016 · 8 comments

Comments

@lexman
Copy link
Collaborator

lexman commented Feb 29, 2016

As stated previously in datasets/geo-boundaries-world-110m#1, some countries are missing.

There are not present in the source data from NaturalEarth, likely because they are too small for the scale (1:110m). I see 4 options :

  • ignore them, because If anyone wants to use this map, it is at high scale, so they wouldn't appear anyway
  • Add them manually, maybe as a point in order to keep perfect junction beetween countries (for example, Andorra is between France and Spain)
  • use a source at smaller scale, wich will result in a bigger json file
  • use a source at smaller scale, and rescale it, but we'll lose perfect junctions between boundaries

Any idea anyone ?

@jalbertbowden
Copy link
Contributor

i like the first option. i also appreciate your initiative here. after looking into this last year, i came to a wall.

@pwalsh
Copy link

pwalsh commented Feb 29, 2016

Those countries are available "Admin 0 - Countries" available here:

http://www.naturalearthdata.com/downloads/10m-cultural-vectors/

If this is the canonical data package for geo/country data, I don't see how we can leave out some internationally recognised countries, so perhaps this zip is a better source from Natural Earth than the one currently being used.

Also for ref. openspending/cosmopolitan#25

@lexman
Copy link
Collaborator Author

lexman commented Feb 29, 2016

So @pwalsh you're heading towards solution 3 or 4. The zip you are speaking about is 200MB instead of 1MB. Should we simplify the geographic shapes to reduce size (but as the simplification is independant on each country, we'll have no guaranty that the counries won't overlap, oce simplified) or keep it big (estimaton 100MB) ?

@pwalsh
Copy link

pwalsh commented Feb 29, 2016

@lexman I don't know, but this is an interesting case for DataPackage, as our use case in Cosmopolitan is to generate an API with decent resolution of polygons per country, I'm not that interested in:

a) the size of the source data package
b) a source lossy to the point of removing countries

So, obviously, a compromise would need to be found, and the compromise is dependant on the expected use cases for the data package in question. My personal though would be that we want, at least, higher resolution than we currently have.

lexman added a commit to lexman/geo-countries that referenced this issue Feb 29, 2016
… : 1:10m scale instead of 1:110m scale because all the countries of the world where not present in the simplified source. In order to solve datasets#1
@lexman
Copy link
Collaborator Author

lexman commented Feb 29, 2016

I've updated data with the more accurate source. Now there are 255 countries in the package. Good news, the geojson is only 25MB, wich seems reasonable to me.

@pwalsh tell me how it goes with the updated data. I'll be happy to know if it solves your issue...

lexman added a commit that referenced this issue Feb 29, 2016
More precise source from NaturalEarth
In order to solve #1
@lexman
Copy link
Collaborator Author

lexman commented Mar 10, 2016

@pwalsh how did it go ? Can I close this issue ?

@lexman lexman mentioned this issue Jun 9, 2016
@jalbertbowden
Copy link
Contributor

jalbertbowden commented Jul 7, 2019

coming here from this issue; countries missing being:
-Hawaii
-Republic of Moldova - is Moldova
-Tahiti
-Zanzibar

  • Hawaii being listed, I'm not sure if that is a missing country or the US state.
  • Moldova is there, not sure if that is correct. going to investigate before reporting back.

@Simobain
Copy link

Simobain commented Sep 2, 2019

What about Kosovo ?
The city is present however we can't find its ISO_A3 code it should be XKX
Source : https://countrycode.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants