Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Don't fail when real Crystal app is already open and serving content #188

Open
davidfstr opened this issue Feb 17, 2024 · 0 comments
Labels
priority-low Low priority items. type-bug Bug that fixes a problem with Crystal's existing features.

Comments

@davidfstr
Copy link
Owner

Currently the test suite makes a hard assumption that the default serving port (2797) is open at the time that tests are run.

However if a real version of Crystal is running and serving content on the default port at the time that tests start running, that assumption will not be correct and various tests will fail.
Screen Shot 2024-01-28 at 4 04 14 PM

Affected tests:

crystal --test crystal.tests.test_load_urls.test_serve_url_never_requires_loading_urls crystal.tests.test_project_migrate.test_can_serve_revisions_from_project_with_major_version_1 crystal.tests.test_project_migrate.test_can_serve_revisions_from_project_with_major_version_2 crystal.tests.test_server.test_when_serve_page_then_safe_headers_included crystal.tests.test_server.test_when_serve_page_then_unsafe_headers_excluded crystal.tests.test_server.test_when_serve_page_with_unknown_non_x_header_then_excludes_header_and_prints_warning crystal.tests.test_server.test_when_serve_page_with_unknown_x_header_then_excludes_header_silently crystal.tests.test_workflows.test_can_download_and_serve_a_static_site crystal.tests.test_workflows.test_can_download_and_serve_a_site_requiring_dynamic_url_discovery crystal.tests.test_workflows.test_can_download_and_serve_a_site_requiring_dynamic_link_rewriting crystal.tests.test_workflows.test_cannot_download_anything_given_project_is_opened_as_readonly crystal.tests.test_workflows.test_can_update_downloaded_site_with_newer_page_revisions
@davidfstr davidfstr added priority-low Low priority items. type-bug Bug that fixes a problem with Crystal's existing features. labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low Low priority items. type-bug Bug that fixes a problem with Crystal's existing features.
Projects
None yet
Development

No branches or pull requests

1 participant