Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License issue #28

Open
frbl opened this issue Mar 25, 2021 · 4 comments · May be fixed by #29
Open

License issue #28

frbl opened this issue Mar 25, 2021 · 4 comments · May be fixed by #29

Comments

@frbl
Copy link

frbl commented Mar 25, 2021

Hey!

First of all, thanks for the great gem! We have a small issue with it though, in that it is MIT licensed, but it depends on colorize, which is GPL licensed. Are you sure the way it is set up right now is correct? Or should you change your license to GPL too?

Best,
Frank

@dbalatero
Copy link
Owner

Huh, I suppose it's broken eh?

Should I pull the gem abruptly and take down all Rails deploys, or…

how do I get myself out of this conundrum? Cut a new gem and drop the colorize dependency?

@frbl
Copy link
Author

frbl commented Mar 25, 2021

haha yeah that sounds like a great idea...

I would start indeed with removing colorize, but I'm not a lawyer and not sure if that's enough. I did found this thread though, of another project that had a similar issue; robolectric/robolectric#1414

But again, I'm not a lawyer, and I just noticed this, so I thought you might want to know.

@dbalatero dbalatero linked a pull request Mar 25, 2021 that will close this issue
@dbalatero
Copy link
Owner

@frbl I created a PR with the library removed (#29). Would you test the branch out and let me know if it still works for you?

@frbl
Copy link
Author

frbl commented Jul 15, 2021

Hi @dbalatero , I'm sorry for the late response, and yes this would work for us! I'm currently not in the opportunity to actually test it out, but I reviewed your PR and that seems perfectly fine. If I get around to actually test it in the near future, I'll let you know. Sorry for not being more helpful, and thanks a lot for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants