Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-gate proxy and service API #1135

Open
zeenix opened this issue Nov 10, 2024 · 0 comments
Open

Feature-gate proxy and service API #1135

zeenix opened this issue Nov 10, 2024 · 0 comments
Labels
api break enhancement New feature or request optimization zbus Issues/PRs related to zbus crate
Milestone

Comments

@zeenix
Copy link
Contributor

zeenix commented Nov 10, 2024

Turns out that LTO isn't perfect so even when binaries using zbus are built with lto = fat, they still end up with API they don't use at all. One main example is busd, where the binary ends up not only with proxy code that it doesn't use at all, this code contributes quite significantly to the size of busd binary. So let's feature gate both proxy and service API so pure services can disable all proxy code and vice versa.

Unfortunately, these features will have to be default and adding new default features would be a breaking change. So it'll have to wait till 6.0.

This will be part of the #304 efforts.

@zeenix zeenix added enhancement New feature or request api break optimization zbus Issues/PRs related to zbus crate labels Nov 10, 2024
@zeenix zeenix added this to the zbus-6.0 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api break enhancement New feature or request optimization zbus Issues/PRs related to zbus crate
Projects
None yet
Development

No branches or pull requests

1 participant