Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make available key types in extendTailwindMerge more strict #293

Closed
dcastil opened this issue Aug 19, 2023 · 1 comment · Fixed by #279
Closed

Make available key types in extendTailwindMerge more strict #293

dcastil opened this issue Aug 19, 2023 · 1 comment · Fixed by #279
Labels
breaking Is breaking change context-v2 Related to tailwind-merge v2 feature Is new feature
Milestone
v2

Comments

@dcastil
Copy link
Owner

dcastil commented Aug 19, 2023

The idea started with this commit from @kachkaev: #279 (comment).

I think the API I want to go for is

extendTailwindMerge<ExtraClassGroupKeys, ExtraThemeKeys>(…)

with only explicitly defined keys being allowed in the config. The types of ExtraClassGroupKeys and ExtraThemeKeys would be unionized together with the default available keys so users don't need to redefine all keys again.
@dcastil dcastil added breaking Is breaking change feature request labels Aug 19, 2023
@dcastil dcastil added this to the v2 milestone Aug 19, 2023
@dcastil dcastil changed the title Make available keys types in extendTailwindMerge more strict Make available key types in extendTailwindMerge more strict Aug 19, 2023
@dcastil dcastil mentioned this issue Aug 20, 2023
Merged
@github-actions
Copy link

This was addressed in release v2.0.0.

@dcastil dcastil added the context-v2 Related to tailwind-merge v2 label Oct 30, 2023
@dcastil dcastil added feature Is new feature and removed feature request labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Is breaking change context-v2 Related to tailwind-merge v2 feature Is new feature
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Make types of available keys more strict and configurable through generics kachkaev/tailwind-merge
1 participant
@dcastil