Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private Tags take element wrong into account #356

Open
lmdulz opened this issue Jul 11, 2023 · 1 comment
Open

private Tags take element wrong into account #356

lmdulz opened this issue Jul 11, 2023 · 1 comment

Comments

@lmdulz
Copy link

lmdulz commented Jul 11, 2023

why does the isPrivateCreator function of the Tag Class check if the element is bigger than 0x00?
that is not a requirement according to the dicom standard?
But its actually a requirement for it not to be between 0001-000F

@pieper
Copy link
Collaborator

pieper commented Jul 11, 2023

Thanks for reporting 👍

For background, when you report an issue, it helps to include a link to the code you are referring too (e.g. like this.

You can also use the "blame" feature of git to get a link to the commit that added the feature (like this).

This commit includes links to the original issues addressed and discussion about the corresponding PR. Here #242 and #243

Can you have a look at these and ideally propose code changes along with sample data and tests, along with a description of why the change is needed to manage any issues you are seeing. Ideally also including comparisons to how other toolkits manage the data.

We are trying to be very careful with changes to this code as we want to avoid regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants