You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Something awkward about the function make_xds_object() is that it requires both residence and HPop and it checks that length(HPop) == length(residence).
It also creates a special case of F_H.xds_object()
Proposed Solution
Since make_xds_object() is supposed to return a template, I think it's probably sensible to
set HPop=rep(1, length(residence) to for make_xds_object()
require a call change_HPop from within xds_setup()
This would keep with the spirit of make_xds_object() and thenF_H.xds_obj() would not be required. It is defined only for use in make_xds_object()
Discussion
I will probably get around to making this change sooner or later, if no one has any specific feedback.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Issue
Something awkward about the function
make_xds_object()
is that it requires bothresidence
andHPop
and it checks thatlength(HPop) == length(residence).
It also creates a special case of
F_H.xds_object()
Proposed Solution
Since
make_xds_object()
is supposed to return a template, I think it's probably sensible toHPop=rep(1, length(residence)
to formake_xds_object()
change_HPop
from withinxds_setup()
This would keep with the spirit of
make_xds_object()
and thenF_H.xds_obj()
would not be required. It is defined only for use inmake_xds_object()
Discussion
I will probably get around to making this change sooner or later, if no one has any specific feedback.
Beta Was this translation helpful? Give feedback.
All reactions