Fix requires for present? method

decidim · Feb 18, 2025 · 6f9eafa · 6f9eafa
1 parent 8bc894c
commit 6f9eafa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/decidim/maintainers_toolbox/github_manager/querier/by_issue_id.rb b/lib/decidim/maintainers_toolbox/github_manager/querier/by_issue_id.rb
@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "base"
+require "active_support/core_ext/object/blank"
 
 module Decidim
   module MaintainersToolbox
@@ -32,14 +33,12 @@ def call
           # @return [Hash]
           def parse(metadata)
             labels = metadata["labels"].map { |l| l["name"] }.sort
-            is_pull_request = metadata.key?("pull_request")
-            is_merged = metadata.key?("pull_request") && metadata["pull_request"].key?("merged_at") && metadata["pull_request"]["merged_at"]
 
             {
               id: metadata["number"],
               state: metadata["state"],
-              is_pull_request: is_pull_request,
-              is_merged: is_merged,
+              is_pull_request: metadata["pull_request"].present?,
+              is_merged: (metadata["pull_request"]["merged_at"].present? rescue false),
               title: metadata["title"],
               labels: labels,
               type: labels.select { |l| l.match(/^type: /) || l == "target: developer-experience" },

diff --git a/spec/lib/decidim/maintainers_toolbox/github_manager/querier/by_issue_id_spec.rb b/spec/lib/decidim/maintainers_toolbox/github_manager/querier/by_issue_id_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "decidim/maintainers_toolbox/github_manager/querier"
+require "decidim/maintainers_toolbox/github_manager/querier/by_issue_id"
 require "webmock/rspec"
 
 RSpec.describe Decidim::MaintainersToolbox::GithubManager::Querier::ByIssueId do