Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReleaseCandidate releases feature #7

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Add ReleaseCandidate releases feature #7

wants to merge 36 commits into from

Conversation

andreslucena
Copy link
Member

@andreslucena andreslucena commented Jul 16, 2024 •
edited
Loading

Until now, the decidim-releaser script only was working for Patch versions (i.e. from v0.28.0 to v0.28.1).

This PR introduces the feature to make Release Candidates using this same tool (i.e. from v0.29.0.dev to v0.29.0.rc1).

For doing that, what I've done is:

  1. Extract the Patch code to its own class (ReleasePatchVersion)
  2. Make a ReleaseCandidateVersion class
  3. Move the common logic to the ReleaserUtils module

After this is merged, the next iteration would be to have a new class from ReleaseMinorVersion (from v0.29.0.rcX to v0.29.0)

As it is specially tricky to actually run this script without making a release, I can confirm that I've used this to create the branches for:

To check that I didn't break anything with the ReleasePatchVersion refactor, I've used this to create the branches for:

I think this is ready for a merge.

@andreslucena
Run webpack rake task for v0.27
7a73236
@andreslucena
Add i18n environment variables to local rspec run
c829d5f
@andreslucena
Replace ByTitle with ByQuery
bdd28ce
@andreslucena
Extract ReleasePatchVersion to its own class and ReleaserUtils module
3b011ef
@andreslucena
Add ReleaseCandidateVersion class
79562a1
@andreslucena
Refactor ReleasePatchVersion so it's consistent with ReleaseCandidate…
19c59a1 
…Version
@andreslucena
Add throttling for GitHub REST API
9b6989f
@andreslucena
Fix requires
135e7e3
@andreslucena
Fix markdownlint offense
76010d9
@andreslucena
Raise exception if system command failed
40c5e29
@andreslucena
Merge branch 'main' into feature/release-candidate-version
abc89d8
@andreslucena
Init the spec_helper for rspec's configuration
ef9807f
@andreslucena
Enable default recommeneded settings for rspec
21a7497
@andreslucena
Use explicit RSpec call in specs
b6e8c6e
@andreslucena
Add .rspec-failures as example status persistence file for rspec
10c512b
@andreslucena
Refactor bump_decidim_version method and extract it to ReleaserUtils
079dfec
@andreslucena
Extract 'releaser repository' shared context
edaa46f
@andreslucena
Improve checks for branches and versions when releasing a RC
a3ec237
@andreslucena
fixup! Extract 'releaser repository' shared context
15a8b53
@andreslucena
Extract #release_branch spec to RC/Patch specs
b5dc3e1
@andreslucena
Move #next_version_number_for_release_candidate method spec to Releas…
93726a4 
…eCandidateVersion spec
@andreslucena
Move #next_version_number_for_patch_release method spec to ReleasePat…
d060c23 
…chVersion spec
@andreslucena
Move rest of the methods specs to ReleaserUtils spec
13e2d44
@andreslucena
Add specs for sanity checks and fix bug in release candidate checks
5725152
@andreslucena
Improve legibility in the finish message
8b7d92e
@andreslucena andreslucena changed the title Run webpack rake task for v0.27 Add ReleaseCandidate releases feature Jul 16, 2024
@andreslucena andreslucena marked this pull request as ready for review July 16, 2024 16:39
alecslupu
alecslupu requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, and i think is good to go.

lib/decidim/maintainers_toolbox/release_candidate_version.rb Outdated

To update, follow these steps:

### 1.1. Update your Gemfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have the policy of one Decidim version, has one ruby version, i would add here also the Upgrade ruby step

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done at f45ddcc

@andreslucena
Copy link
Member Author

@alecslupu this is ready for another round (I forget about this PR and it'd be nice to have it for the v0.30 release :D)

This was referenced Feb 12, 2025
Merged
Closed
alecslupu
alecslupu previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM . let's see how it behaves ..

@andreslucena
Copy link
Member Author

andreslucena commented Feb 18, 2025 •
edited
Loading

@alecslupu this is ready for another round!

I try it out with #14096 and #14109, and apart from some missing requires (like using the present? method from ActiveSupport without doing the require in the file that was necessary) I also found another bug related to the tests: we were doing the tests execution once the release branch was prepared and we should do it at the begging of the process, so it's much easier to restart and try again. This is fixed too.

About the documentation, the instructions are available at #14066, so we can merge that after this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecslupu alecslupu alecslupu left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@alecslupu alecslupu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreslucena @alecslupu