Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump decidim from v0.28.0 to v0.28.1 #128

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Bump decidim from v0.28.0 to v0.28.1 #128

merged 5 commits into from
Jul 12, 2024

Conversation

andreslucena
Copy link
Member

As the title says, there's a new version of Decidim so we need to update

@andreslucena
Copy link
Member Author

To finish the update process, once this is deployed in the production database we'll need to run

bin/rails decidim:upgrade:fix_orphan_categorizations

See more information at https://github.com/decidim/decidim/releases/tag/v0.28.1

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@andreslucena please merge when you need.

Suggested in the code review
@fblupi fblupi self-requested a review June 20, 2024 09:27
Copy link
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreslucena I receive this error while compiling the assets.

(58:6) /Users/fbo/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/decidim-meetings-0.28.1/app/packs/stylesheets/decidim/meetings/_item.scss The `min-w-24` class does not exist. If `min-w-24` is a custom class, make sure it is defined within a `@layer` directive.

  56 | 
  57 |     &__lg {
> 58 |       @apply w-fit justify-center [&>*]:px-2 min-w-24 h-[8.5rem];
     |      ^
  59 |     }
  60 | 

I tried deploying it in Heroku thinking it was something on my local, but it's failing with the same error too.

I don't get why it's not failing in the CI then.

@andreslucena
Copy link
Member Author

andreslucena commented Jun 20, 2024

(58:6) /Users/fbo/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/decidim-meetings-0.28.1/app/packs/stylesheets/decidim/meetings/_item.scss The min-w-24 class does not exist. If min-w-24 is a custom class, make sure it is defined within a @layer directive.

I can reproduce this same error locally with

SECRET_KEY_BASE=potato RAILS_ENV=production bin/rails assets:precompile

I think it's related to the tailwindcss version that we're using and the backport that introduced this change in v0.28 (#12787). This is using a directive that isn't available in the version of tailwind that we're using in v0.28.

I made a quick fix in bfb306c, just to check out if this is indeed the problem, so we can also introduce that change in release/0.28-stable (and do a v0.28.2 with this fix).

This is something that @microstudi mentioned a couple of weeks ago, but I could only reproduce in this app with this change. Locally with a new v0.28.1 app I could not reproduce this bug, as I see that it generates the app with tailwind 3.4.4.

I think the actual issue is that we're using the caret character (^) and this applies to minor and patch versions, and we should use the tilde character (~), that applies only to patch versions. With that, I understand that we would have detected the problem in CI (as we should have done).

@fblupi fblupi self-requested a review June 20, 2024 13:58
Copy link
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully executed it locally after applying the latest change.

Seems there's an error in the CI but, as it's not related with this and the tests run successfully locally, I approve it.

@fblupi fblupi merged commit 82af369 into master Jul 12, 2024
1 check passed
@fblupi fblupi deleted the deps/decidim/0.28.1 branch July 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants