Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] - "pepr build --no-embed" flag writes stderr stream with exitcode 0 #1659

Open
btlghrants opened this issue Jan 14, 2025 · 0 comments
Milestone

Comments

@btlghrants
Copy link
Collaborator

btlghrants commented Jan 14, 2025

Background

While working #1654 I discovered that we get strange text on stderr when running the pepr build command with the --no-embed flag:

The module still appears to build (successfully, maybe..?).
The build command returns an exit code of "0".
The stdout stream comes back empty.
The stderr stream comes back with containing an error like: "Error: Cannot find module [...])

This should be investigated. Current behavior codified in (upcoming) integration test for the pepr build cli:

  • /integration/cli/build.noembed.test.ts : build > builds a module > for use as a library > builds

Definition of Done

  1. figure out whether this is a "real" error or just a matter of test setup / config, and
  2. fix the error (if it is one).
@btlghrants btlghrants converted this from a draft issue Jan 14, 2025
@btlghrants btlghrants added the bug Something isn't working label Jan 14, 2025
@btlghrants btlghrants changed the title --no-embed flag writes to stderr stream even when successful --no-embed flag writes stderr stream with exitcode 0 Jan 14, 2025
@btlghrants btlghrants moved this from 📋 Backlog to 🆕 New in Pepr Project Board Jan 14, 2025
@btlghrants btlghrants changed the title --no-embed flag writes stderr stream with exitcode 0 "pepr build --no-embed" flag writes stderr stream with exitcode 0 Jan 14, 2025
@btlghrants btlghrants moved this from 🆕 New to Questions in Pepr Project Board Jan 14, 2025
@btlghrants btlghrants removed the bug Something isn't working label Jan 14, 2025
@cmwylie19 cmwylie19 moved this from Questions to 📋 Backlog in Pepr Project Board Jan 15, 2025
@cmwylie19 cmwylie19 changed the title "pepr build --no-embed" flag writes stderr stream with exitcode 0 [SPIKE] - "pepr build --no-embed" flag writes stderr stream with exitcode 0 Jan 15, 2025
@cmwylie19 cmwylie19 added this to the v0.44.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants