-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] "pepr build --version <version>" writes pepr version to stdout #1661
Comments
Blocked waiting on #1642 to merge with |
While working on this, I noticed some test flakes on my dev environment. I've created https://github.com/defenseunicorns/pepr/tree/hotfix-local-integration-failure to dig into the root cause here before I make progress on this issue. |
## Description In support of #1661, this PR fixes issues with test setup for integration tests. End to End Test: <!-- if applicable --> (See [Pepr Excellent Examples](https://github.com/defenseunicorns/pepr-excellent-examples)) ## Related Issue Relates to #1661 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Barrett <[email protected]>
It turns out
versus
This internal slack thread discusses options, to include removing the flag if users don't use it. |
Background
While working #1654 I discovered that when trying to use the --version option we appear to just get the result of
pepr --version
(almost like Commander.js is interpreting the --version flag overly-eagerly & not letting the sub command parse it..?).This should be investigated. Current behavior codified in (upcoming) integration test for the
pepr build
cli:Definition of Done
The text was updated successfully, but these errors were encountered: