Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck to project #1706

Open
samayer12 opened this issue Jan 22, 2025 · 0 comments
Open

Add shellcheck to project #1706

samayer12 opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@samayer12
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We use a couple of shell scripts in this project but do not lint them like we do typescript files. Shellcheck is a common tool for this task that will ensure code-quality. We should add shellcheck to our commit hooks and enforce it in CI.

Describe the solution you'd like

  • Given a .sh file is modified
  • When a commit occurs
  • Then shellcheck lints the .sh file

Describe alternatives you've considered

N/A

Additional context

  • .lintstaged.json will need to be modified to trigger shellcheck on changes to .sh files.
@samayer12 samayer12 added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant