Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual physical mail address input #1717

Open
Ceshion opened this issue Jun 25, 2020 · 3 comments · May be fixed by #1775
Open

Manual physical mail address input #1717

Ceshion opened this issue Jun 25, 2020 · 3 comments · May be fixed by #1775
Labels

Comments

@Ceshion
Copy link
Collaborator

Ceshion commented Jun 25, 2020

image

I propose the addition of an arbitrary-length list of form fields to the snail mail form (mock above), for users to input addresses manually. In addition to manual input, I think we should add addresses to the letter schema so we can add default addresses as part of the template, if the entering user is aware that the Civic Information API data is incomplete.

This will be necessary in order for users to reliably get letters sent to representatives who need to see them, as right now there is no alternative if the API is missing data. As usual, I am more than happy to lead development on this.

@blackmad
Copy link
Contributor

Hey Ceshion -

Thanks for writing this out, mocking it up and offering to lead.

some feedback on the form

  • It needs a "name" line tooin the form
  • I think it should be default collapsed to not overwhelm the user
  • button is named something like "add a missing rep" and then maybe "add another" after that?
  • maybe we need a line that's like "sometimes we can't find addresses for local officials, you can add your own ..."?

I'm happy to lead the work on adding manual addresses to the templates.

-d

@Ceshion
Copy link
Collaborator Author

Ceshion commented Jun 27, 2020

* It needs a "name" line too in the form

I 100% agree and planned on it, just missed it for the mock.

* I think it should be default collapsed to not overwhelm the user

Also agree, I would think the form would not show up until a user clicks the button to add someone

* button is named something like "add a missing rep" and then maybe "add another" after that?

works for me!

* maybe we need a line that's like "sometimes we can't find addresses for local officials, you can add your own ..."?

I like that idea, should we also include a link to the feedback for the Civic API so they can also be added officially? or collect the reps that are added this way to do that ourselves?

@blackmad please do! I saw already we have addresses coming in as part of letter requests, so that may also be a good way to handle this- and have manual input just as a backup

@blackmad
Copy link
Contributor

blackmad commented Jun 28, 2020 via email

@Ceshion Ceshion linked a pull request Jul 3, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants