add manual address entry to letter form #1775
Conversation
Ceshion
requested review from
averymcguirt,
teddywilson,
minicreative,
serifluous and
shortcircuit3
as code owners
src/components/common/PropTypes.ts
Outdated
| addText: string | ((listItems: Array<TModel>) => string); | ||
| modelFactory: () => TModel; | ||
| updateModel: (value: Array<TModel>) => void; | ||
| eachRender: (updateModel: (value: TModel) => void) => JSX.Element; |
There was a problem hiding this comment.
maybe "renderChild" or "renderEntry" or "renderListEntry"?
There was a problem hiding this comment.
updateModel => onItemUpdated?
There was a problem hiding this comment.
I think renderListItem and onListItemUpdated to keep consistent with the rest of it
src/components/common/PropTypes.ts
Outdated
| export interface DynamicListProps<TModel> { | ||
| addText: string | ((listItems: Array<TModel>) => string); | ||
| modelFactory: () => TModel; | ||
| updateModel: (value: Array<TModel>) => void; |
There was a problem hiding this comment.
onItemsUpdated? onListItemsUpdated?
There was a problem hiding this comment.
This, I like- it has the potential to be used for more than just updating the model, and I will include it in a new commit 😊
| @@ -0,0 +1,6 @@ | |||
| export interface DynamicListProps<TModel> { | |||
| addText: string | ((listItems: Array<TModel>) => string); | |||
| modelFactory: () => TModel; | |||
There was a problem hiding this comment.
emptyModelFactory? defaultModelFactory? createEmptyModel?
There was a problem hiding this comment.
I am not sure those names would be appropriate, since the consumer could definitely create a filled or partially-filled model through a closure, and there would not be anything non-default that seems like it would call for using "default". Is there something you're thinking of that I'm missing?
|
|
||
| type AddressInputProps = { | ||
| /** callback function for every time the address is updated */ | ||
| updateParent: (a: LobAddress) => void; |
This PR adds a generic arbitrary-length list component, used in the letter form to allow users to input addresses that are not populated automatically from the Civic API.
Closes #1717