Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make build-c" fails to build sample apps #381

Open
squillace opened this issue Apr 12, 2023 · 3 comments
Open

"make build-c" fails to build sample apps #381

squillace opened this issue Apr 12, 2023 · 3 comments
Labels
🐛 bug Something isn't working 🚧 maintainer issue An issue that is being tackled by maintainers

Comments

@squillace
Copy link
Contributor

Description of the bug
make build-c
make -C examples/multi_capability-demo-clang/ clean
make[1]: Entering directory '/home/squillace/work/squillace/spiderlightning/examples/multi_capability-demo-clang'
rm -rf bindings/
mkdir bindings/
make[1]: Leaving directory '/home/squillace/work/squillace/spiderlightning/examples/multi_capability-demo-clang'
make -C examples/multi_capability-demo-clang/ bindings
make[1]: Entering directory '/home/squillace/work/squillace/spiderlightning/examples/multi_capability-demo-clang'
wit-bindgen c --import ../../wit/keyvalue.wit --out-dir bindings/
Error: expected an identifier or string, found '('
--> ../../wit/keyvalue.wit:4:19
|
4 | static open: func(name: string) -> expected<keyvalue, keyvalue-error>
| ^
make[1]: *** [Makefile:21: bindings] Error 1
make[1]: Leaving directory '/home/squillace/work/squillace/spiderlightning/examples/multi_capability-demo-clang'
make: *** [Makefile:158: build-c] Error 2

To Reproduce
make build-c

Additional context

@squillace squillace added 🐛 bug Something isn't working 🚧 maintainer issue An issue that is being tackled by maintainers labels Apr 12, 2023
@Mossaka
Copy link
Member

Mossaka commented Apr 12, 2023

Thanks for rasing this issue @squillace . make build-c is actually not ran by the CI/CD so its currently broken. I will take "adding make build-c to CI" as a follow up

@Mossaka
Copy link
Member

Mossaka commented Apr 12, 2023

But to just fix the issue you ran into - please make sure that you have wit-bindgen tag v0.2.0 installed instead of the latest wit-bindgen

@mboersma
Copy link
Contributor

mboersma commented Aug 4, 2023

cargo install --git https://github.com/bytecodealliance/wit-bindgen \
  wit-bindgen-cli --tag v0.2.0

Maybe that should go the docs somewhere? Took me a bit to figure out the right incantation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🚧 maintainer issue An issue that is being tackled by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants