-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch all computers without a date filter. #37219
Open
yedidyacohenpalo
wants to merge
6
commits into
master
Choose a base branch
from
yc/jamf_protect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+175
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedidyacohenpalo
changed the title
done
fetch all computers parameter to enable fetching without a date filter.
Nov 14, 2024
yedidyacohenpalo
changed the title
fetch all computers parameter to enable fetching without a date filter.
fetch all computers without a date filter.
Nov 14, 2024
jbabazadeh
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! please see my comments
Packs/JamfProtect/Integrations/JamfProtectEventCollector/JamfProtectEventCollector.yml
Show resolved
Hide resolved
Packs/JamfProtect/Integrations/JamfProtectEventCollector/JamfProtectEventCollector_test.py
Show resolved
Hide resolved
Packs/JamfProtect/Integrations/JamfProtectEventCollector/JamfProtectEventCollector.py
Show resolved
Hide resolved
jbabazadeh
reviewed
Nov 17, 2024
Packs/JamfProtect/Integrations/JamfProtectEventCollector/JamfProtectEventCollector.yml
Outdated
Show resolved
Hide resolved
jbabazadeh
reviewed
Nov 17, 2024
Packs/JamfProtect/Integrations/JamfProtectEventCollector/README.md
Outdated
Show resolved
Hide resolved
jbabazadeh
reviewed
Nov 17, 2024
Packs/JamfProtect/Integrations/JamfProtectEventCollector/README.md
Outdated
Show resolved
Hide resolved
jbabazadeh
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
…rotectEventCollector.yml Co-authored-by: JudithB <[email protected]>
…E.md Co-authored-by: JudithB <[email protected]>
…E.md Co-authored-by: JudithB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: CIAC-12027
Description
A few sentences describing the overall goals of the pull request's commits.
Must have