Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented code for the vehicle fuel bonus component? #274

Open
HonkingGoose opened this issue Aug 15, 2020 · 1 comment
Open

Remove commented code for the vehicle fuel bonus component? #274

HonkingGoose opened this issue Aug 15, 2020 · 1 comment
Labels
code-enhancement Code, polish, performance, etc. enhancements

Comments

@HonkingGoose
Copy link
Contributor

While going through the component templates, I found this code that's commented out.
I didn't remove this code, as I don't know if/when you'll need it.

<!-- <div class="col-12 col-lg-6">
<table class="table table-sm table-hover fixed-width">
<thead class="text-center">
<tr>
<th colspan="4">
<div class="merged-input-group mx-auto">
<div class="input-group">
<span class="input-group-addon">Acceleration times* for</span>
<select class="form-control" [(ngModel)]="trainSizeIdx" (ngModelChange)="updateTable()">
<option *ngFor="let size of trainSizes" [ngValue]="size.idx">{{size.name}}</option>
</select>
<span class="input-group-addon">train</span>
</div>
</div>
</th>
</tr>
<tr>
<th>Speed</th>
<th>
<app-factorio-icon [icon]="dataService.getFactorioIcon('Wood')"></app-factorio-icon>
<app-factorio-icon [icon]="dataService.getFactorioIcon('Coal')"></app-factorio-icon>
</th>
<th>
<app-factorio-icon [icon]="dataService.getFactorioIcon('Solid_fuel')"></app-factorio-icon>
</th>
<th>
<app-factorio-icon [icon]="dataService.getFactorioIcon('Rocket_fuel')"></app-factorio-icon>
</th>
</tr>
</thead>
<tbody class="text-center">
<tr *ngFor="let item of tableData">
<td>{{item?.speed}}</td>
<td>{{item?.timeBasic}}</td>
<td>{{item?.timeSolid}}</td>
<td>{{item?.timeRocket}}</td>
</tr>
</tbody>
</table>
<span class="text-muted">*Experimental Data, not complete, contact me if you have more.</span>
</div> -->

@deniszholob
Copy link
Owner

I dont fancy that section in general, #187 talks about it a bit. Not sure what do do with it yet, gotta think about it....

@deniszholob deniszholob added the code-enhancement Code, polish, performance, etc. enhancements label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-enhancement Code, polish, performance, etc. enhancements
Projects
None yet
Development

No branches or pull requests

2 participants