Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic way of appending settings to settings.local.php #46

Open
marcelovani opened this issue Sep 11, 2017 · 0 comments
Open

More generic way of appending settings to settings.local.php #46

marcelovani opened this issue Sep 11, 2017 · 0 comments

Comments

@marcelovani
Copy link
Contributor

Background

Currently, the site:settings command will append the contents of a template (https://github.com/dennisinteractive/drupal_console_commands/blob/master/src/Command/Site/Settings/Includes/Drupal8/settings.local.php) onto settings.local.php.

This is not very generic, it makes the assumption that everyone uses the modules in the template.

Proposed solution

  • Remove the template above.
  • Do not include the template
  • Add new section on sites yml containing the settings for each env i.e.
  settings:
    config:
      stage_file_proxy.settings:
        origin: cdn.subscriptions.dennis.co.uk
      cdn.settings:
        mapping:
          domain: http://subscriptions.vm8.didev.co.uk

The generated settings.local.php should look like this:

$config['stage_file_proxy.settings']['origin'] = 'cdn.subscriptions.dennis.co.uk';
$config['cdn.settings']['mapping']['domain'] = 'http://subscriptions.vm8.didev.co.uk';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant