Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno 1.7 fmt checks markdown files by default #9387

Closed
jeiea opened this issue Feb 3, 2021 · 4 comments
Closed

deno 1.7 fmt checks markdown files by default #9387

jeiea opened this issue Feb 3, 2021 · 4 comments

Comments

@jeiea
Copy link
Contributor

jeiea commented Feb 3, 2021

Reproducible steps

  1. Create README.md with the following.
Remember, contributions to this repository should follow its contributing guidelines and code of conduct.
  1. Run deno fmt --check in the same directory.

Expected behavior

deno 1.6.3 emits the following.

Checked 0 file

Actual behavior

deno 1.7.0, 1.7.1 emits the following.

from \\README.md:
1 | -Remember, contributions to this repository should follow its contributing guidelines and code of conduct.
1 | +Remember, contributions to this repository should follow its contributing
2 | +guidelines and code of conduct.

Additional context

deno fmt help says:

OPTIONS:
        --check                    Check if the source files are formatted
        --ext <ext>                Set standard input (stdin) content type [default: ts]  [possible values: ts, tsx, js, jsx, md]

--ext ts didn't work. I think it's a regression.

This blocks this pull request.

@nayeemrmn
Copy link
Collaborator

This is expected behaviour. We got markdown support for deno fmt and it's enabled without flags. The --ext specifies how to interpret stdin, as it says.

@jeiea
Copy link
Contributor Author

jeiea commented Feb 3, 2021

Do you have desirable solution for this? I can't sure deno's markdown formatting is acceptable to every repository. Is there any option for this?

@nayeemrmn
Copy link
Collaborator

Do you have desirable solution for this? I can't sure deno's markdown formatting is acceptable to every repository. Is there any option for this?

It should be if they are using deno fmt, just run deno fmt.

@Soremwar
Copy link
Contributor

Soremwar commented Feb 3, 2021

Add //deno-fmt-ignore-file to the markdown

@jeiea jeiea closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants