Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last updated by human not set when Vet Center Service is saved/updated. #15124

Closed
2 tasks
Tracked by #18003
swirtSJW opened this issue Sep 6, 2023 · 10 comments
Closed
2 tasks
Tracked by #18003
Assignees
Labels
CY24-Q2 Calendar year Q2 2024 priority Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Revision logs sitewide Vet Center CMS managed product owned by Facilities team

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Sep 6, 2023

Describe the defect

When an editor edits a Vet Center Service, they have to do so using the Inline Entity Form on the Vet Center node. This does not update the last saved by an editor field on the Vet Center Service node
image

To Reproduce

Steps to reproduce the behavior:

  1. Go to a vet center'/node/3719/edit'
  2. Scroll down to the services, then click the edit button on the service.
  3. Make a change to the service.
  4. Save the Vet Center Facility node.
  5. Find the service you just edited in /admin/content?title=&type=vet_center_facility_health_servi&moderation_state=All&owner=All
  6. Look at the date and time of your revision, notice it does not match the date of the Last saved by a human field.

AC / Expected behavior

  • The last updated field to the IEF form is hidden.
  • When a Vet Center Service is saved by a human, the last updated date is set accordingly.
@swirtSJW swirtSJW added Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Vet Center CMS managed product owned by Facilities team labels Sep 6, 2023
@mmiddaugh
Copy link
Contributor

Depending on changes, the new "Vet Center content review" KB article which was written to support Vet Center editors in reviewing/updating their content (currently in draft) may need to be updated.

@mmiddaugh
Copy link
Contributor

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Feb 14, 2024

This could be resolved by removing inline entity field

@xiongjaneg
Copy link
Contributor

moved larger IEF removal to #17374

@omahane
Copy link
Contributor

omahane commented Feb 29, 2024

@xiongjaneg I have been working on this and the #15125 most of the day, and neither changes are able to made with config, as Michael and I expected. As a result, to try to do this will take custom coding that I don't think we want to do if we're intending to remove IEF from Vet Centers anyway. Can we discuss another Drupal priority ticket?

@xiongjaneg
Copy link
Contributor

@omahane Absolutely makes sense. I'll move both of those tickets back to backlog. I've moved #17191 address block work to high priority. cc @mmiddaugh @jilladams

@xiongjaneg
Copy link
Contributor

IEF removal first ticket is #17374

@davidmpickett
Copy link
Contributor

This defect will be resolved once the IEF changes are implemented. Leaving this defect in backlog to confirm and close after #18003

@davidmpickett davidmpickett added the Blocked Issues that are blocked on factors other than blocking issues. label May 24, 2024
@Agile6MSkinner Agile6MSkinner removed the Blocked Issues that are blocked on factors other than blocking issues. label Jul 1, 2024
@jilladams
Copy link
Contributor

Can be validated / closed when #18003 ships

@davidmpickett
Copy link
Contributor

Verified on Staging

Screenshot 2024-08-19 at 1 59 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Revision logs sitewide Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

7 participants