Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-conflict CAP data push branch and move 13777 off swirt's fork #16771

Closed
5 of 8 tasks
swirtSJW opened this issue Jan 8, 2024 · 2 comments
Closed
5 of 8 tasks

De-conflict CAP data push branch and move 13777 off swirt's fork #16771

swirtSJW opened this issue Jan 8, 2024 · 2 comments
Assignees
@swirtSJW
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Jan 8, 2024 •
edited
Loading

User Story or Problem Statement

The PR #13777 for pushing CAP data is blocked on lighthouse.

There are two problems:

  • It has a bunch of conflicts because we have done other work on our LH Push code in the 9 months since it was created.
  • It is on Swirt's fork which may vaporize when he leaves the project.

Steps for Implementation

Acceptance Criteria

  • Code is has all conflicts resolved
  • Code is moved to a PR based on branch rather than swirt's fork.
  • Relevant connections are made between the new PR and the old PR and the issue.
  • Important information from the old PR description and comments is moved to the new PR.

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@swirtSJW swirtSJW added Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Vet Center CMS managed product owned by Facilities team labels Jan 8, 2024
@swirtSJW swirtSJW self-assigned this Jan 8, 2024
@swirtSJW swirtSJW mentioned this issue Jan 8, 2024
Closed
22 tasks
@swirtSJW swirtSJW removed the Needs refining Issue status label Jan 10, 2024
@jilladams jilladams changed the title De-conflict and move 13777 off swirt's fork De-conflict CAP data push branch and move 13777 off swirt's fork Jan 10, 2024
@jilladams jilladams added the Drupal engineering CMS team practice area label Jan 10, 2024
@swirtSJW swirtSJW mentioned this issue Jan 12, 2024
Draft
29 tasks
@swirtSJW
Copy link
Contributor Author

This is now the new integration branch. Deconflicted and in its own branch on the base repository. #16837

@swirtSJW
Copy link
Contributor Author

I added QA steps and notes about what work remains to be done once LH unblocks us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swirtSJW swirtSJW

Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swirtSJW @jilladams