-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables on Benefits detail pages no longer have margins #16852
Comments
@FranECross Create backlog ticket to have other tables reviewed/fixed if necessary. |
Code has been merged. Will close next sprint pending prod verification |
@laflannery This has been merged and live on prod. Can you take a look when you get a chance thank you! |
@chriskim2311 This looks great, thanks! I also followed up with Randy H in the original slack thread to let her know this was all set |
Closing verified in prod! |
Additional ticket created to audit PW team's other products/features to determine if margins or captions are missing elsewhere - #17419 |
Background
Another issue that seems to have resulted from the automated table migration (tables that were previously not using the
<va-table>
now are) is that there is no longer a margin between the tables. The standard<table>
element using to had a margin of 2em on the top and bottom but now that is not present.This issue (along with the along issues such as the missing table caption) was brought to our attention by Randi H: Slack thread. I did also ask in the DST slack channel if the fix to add margins would need to be done at the component level or at the template level and they said on the template, which would be something for our team to handle (assuming I'm understanding things correctly)
Description
On the benefits details pages, there are no margins between the tables so they are displaying very close together and this doesn't look very nice. An example page this can be seen on is the Disability compensation rates page. If you open the accordions, you can see the tables there are bunched together:
AC / Expected behavior
<va-table>
should have space between themTeam
Please check the team(s) that will do this work.
The text was updated successfully, but these errors were encountered: