Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables on Benefits detail pages no longer have margins #16852

Closed
1 of 7 tasks
laflannery opened this issue Jan 16, 2024 · 6 comments
Closed
1 of 7 tasks

Tables on Benefits detail pages no longer have margins #16852

laflannery opened this issue Jan 16, 2024 · 6 comments
Assignees
Labels
Defect Something isn't working (issue type) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

Background

Another issue that seems to have resulted from the automated table migration (tables that were previously not using the <va-table> now are) is that there is no longer a margin between the tables. The standard <table> element using to had a margin of 2em on the top and bottom but now that is not present.

This issue (along with the along issues such as the missing table caption) was brought to our attention by Randi H: Slack thread. I did also ask in the DST slack channel if the fix to add margins would need to be done at the component level or at the template level and they said on the template, which would be something for our team to handle (assuming I'm understanding things correctly)

Description

On the benefits details pages, there are no margins between the tables so they are displaying very close together and this doesn't look very nice. An example page this can be seen on is the Disability compensation rates page. If you open the accordions, you can see the tables there are bunched together:
image

AC / Expected behavior

  • Instances of <va-table> should have space between them
  • Design Review
  • Additional FE ticket is written to examine other all templates and determine if the fix done on Benefits detail pages needs to be made elsewhere

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@laflannery laflannery added the Needs refining Issue status label Jan 16, 2024
@laflannery laflannery changed the title <Insert summary of task> Tables on Benefits detail pages no longer have margins Jan 16, 2024
@laflannery laflannery added VA.gov frontend CMS team practice area Public Websites Scrum team in the Sitewide crew labels Jan 16, 2024
@FranECross
Copy link

@FranECross Create backlog ticket to have other tables reviewed/fixed if necessary.

@chriskim2311
Copy link
Contributor

chriskim2311 commented Feb 13, 2024

Code has been merged. Will close next sprint pending prod verification

@chriskim2311
Copy link
Contributor

@laflannery This has been merged and live on prod. Can you take a look when you get a chance thank you!

@laflannery
Copy link
Contributor Author

@chriskim2311 This looks great, thanks! I also followed up with Randy H in the original slack thread to let her know this was all set

@chriskim2311
Copy link
Contributor

Closing verified in prod!

@FranECross
Copy link

Additional ticket created to audit PW team's other products/features to determine if margins or captions are missing elsewhere - #17419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't working (issue type) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants