-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make required services unable to be removed or archived #17676
Comments
This ticket doesn't yet account for archiving / removing optional services as an editor. The same proces/mechanism should apply to Editors handling optional services. |
@davidmpickett I was looking at your comment on #17929 and was thinking that this box about required or optional services could be clearer, something like the following: Required servicesOptional services |
Great edits! I was going to say, "won't it be hard to have the header change?" but then I realized it won't be any harder than changing the sentence that says "This is an optional service." You'll be doing conditional form alters no matter what and this makes it much clearer at a glance. |
@jilladams @Agile6MSkinner @davidmpickett In reviewing the PR, I found something we'll want to add to the IEF removal work: #18321 |
User Story or Problem Statement
As a user with privilege to edit facility services, I want to be assured that I cannot "remove" or archive a facility service that is required.
Acceptance Criteria
Implementation steps
The most certain way is to add some server-side validation, like a constraint, that checks whether a service is required and throws an error when the user submits a form that would archive a service. Of course, we'd need to not throw it if the user is a content admin or admin, as it may actually be necessary to do this.hasAdminRole()
is not true.The text was updated successfully, but these errors were encountered: