Draft updated editorial flow for updated Vet Center services

[davidmpickett]

User Story or Problem Statement

Vet Center Facility Services are currently added to Vet Centers using the Inline Entity Form (IEF). This creates problems as it circumvents a lot of the basic content moderation logic built into the Drupal CMS. We will need to replace the IEF with either a Entity Browser - Table or a View. There are subtle variations to how those operate in Drupal. One would mean editors edit Services in a modal. Another would mean editors edit Services in a new tab.

AS A Facilities PM/PO or Drupal Engineer
I NEED An overall flow of the proposed new editorial experience for Vet Center editors adding services
SO THAT I can decide on the Drupal implementation path

Design

Vet Center forms Figma

Description or Additional Context

• Mural mock up of current flow
• Example Vet Center Service interface
• Drupal feasibility spike

Screenshot of current interface (first screen only)

Acceptance Criteria

• Proposed flow(s) are documented in Figma
• Help text in flows have been reviewed by UX
• Flows are reviewed with UX Lead, Product, Engineering, Content, and Accessibility
• Flows are sent to VA UX Lead for sign off
• Follow up tickets are stubbed

[davidmpickett]

Note that @omahane has a working proof of concept of a view that recreates a lot of the IEF functionality

[jilladams]

From UX Sync:

• Good to document the plan as a flow, for our own sake's and CMS team reference
• Do not need to start from scratch. Can join UX up with Christian to document / map out his intentions. He has a draft plan as a starting point.

[thejordanwood]

Pointing this at a 5. I don't think it will take long to document the flows, but want to leave room for collaboration and reviews.

[aklausmeier]

@thejordanwood As you are reviewing and documenting this particular flow, this is a great opportunity to review help text and identify areas for improvements. I would assume light edits could be done in this ticket but if larger lifts are identified we could discuss how to address as part of Vet Center 2.0 work.

cc @mmiddaugh @jilladams @davidmpickett

[thejordanwood]

@omahane @davidmpickett I've mocked this up in the Vet Centers forms Figma file. Can ya'll review to make sure that I'm on the right track?

Some notes:

• Here's the latest preview link for Christian's proof of concept.
• I like the proof of concept that Christian came up with and don't see any red flags for allowing add/edit/removal of a service to open in a different tab. Just to clarify for myself: Is this Option 3 mentioned in this comment?
• I ask questions and point out some changes in the Figma comments.
• I had minimal edits to help text (shocker!), but please point out any text you feel could be better @davidmpickett.

Edit: We can discuss when I'm back on 4/29. Please leave any comments in the ticket or in Figma if you review in the meantime.

[jilladams]

We discussed the flow during UX sync. Notes from that convo:

• Need Facility selection (Vet Center field) to appear on Create and Edit Vet Center facility services
• Need to understand what happens when we remove a Facility Service from a Vet Center -- does that archive the Facility service?
  • Are Facility Services not associated with a Facility valuable? should they be archived?
  • Are Remove & Delete the same?
  • What does Remove do if not?
  • @omahane is going to check how archiving services works on VAMCs today
• Need to discuss character counts and help text a bit more in the Figma

[omahane]

Archiving a VAMC Facility health Service

Did a little searching. The archiving is straightforward. It changes the moderation state. It's done by an editor on the VAMC Service. That's it.

Archiving a Vet Center Facility Service

• This can also be done by a Vet Center editor

Removing a Vet Center Facility service

• removing a service in the IEF removes the facility from the facility field of the service and resaves the service
• this resave also changes the name of the Vet Center service, from "Duluth Vet Center - Homeless Veteran Care" to "- Homeless Veteran Care".
• This appears to the sever the connection but leads to services with only half a name. There are 15 of these in prod.

Corresponding Entity Reference

This is set for Vet Centers

• /admin/config/content/cer
• Vet Center Health Services To Vet Center vet_center_health_services_to_vet_center_office
  • field_office
  • field_health_services
  • append Yes

Creating a service as a node adds it to the facility.

• Per CER's pattern
• This saves the service
• It also updates the facility

Vet Center editors cannot delete services. They can do the following:

• Save
• Save draft and continue editing
• Unlock

[davidmpickett]

Re character counts. Here is an excel doc sorted by character counts on Service Descriptions. The range is incredibly wide 0-5000 with an average of 373. This field is not a good fit for character counts.

vet-center-services.xlsx

[omahane]

@davidmpickett asked in Figma about prepopulating content from the Vet Center to a newly created service. This can be done with tokens. We currently do it with non-clinical services. Here's the link on the view of content on a top task page:

<p><a href="/node/add/vha_facility_nonclinical_service?field_service_name_and_descripti=1027&field_administration={{ arguments.field_administration_target_id }}" target="_blank">Add facility (opens in a new window)</a></p>\

The Service field on the non-clinical service has a default value that reads in the value passed, using this token
[current-page:query:field_service_name_and_descripti]

This is how the Service itself is populated when clicking on this link:

[omahane]

@davidmpickett Asked in Figma whether we could have the grey box showing that we have precreated content without the tooltip icon. The answer is yes. As long as you don't populate the "Tooltip Description" field, no icon shows.

Here's an example of a test I did locally in a Billing and Insurance top task page:

[davidmpickett]

@omahane I started a real basic stub for your actual implementation. #18003

Some of the other tickets in this epic might also be blockers to starting that ticket, but I didn't see any other ticket that addresses actually doing the work so wanted to get something in place

[thejordanwood]

@aklausmeier This is ready for your review! The design can be seen in the Vet Center forms Figma.

[aklausmeier]

@thejordanwood Looks great including the new help text!

[jilladams]

Closing with Amanda's signoff. #18003 is queued for next refinement. Go team!