Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next-Build: Expose CMS "registration required" field information from events to the front-end #17735

Open
1 task
timcosgrove opened this issue Apr 4, 2024 · 6 comments
Labels
Accelerated Publishing Events product maintained by Public Websites team Needs refining Issue status next-build FE Repository that will replace content-build. Uses NextJS, builds static pages. Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@timcosgrove
Copy link
Contributor

timcosgrove commented Apr 4, 2024

Status

[2025-01-09] [Fran] Moved to the backlog until NB engineers are available, and/or decisions made on which team changes code.

Description

In #16578 we added markup to content-build to process a "registration required" field.

That markup was not also added to next-build. Next build events are now live in production, and this needs to be implemented to get back to prod parity with the old content-build.

Background & implementation details

See #16578 for the original work and department-of-veterans-affairs/content-build#1997 for the code changes that were implemented in Content Build.

Acceptance criteria

Preview Give feedback

AC1: FE displays Editor's choice for Call to Action of 'Register'

GIVEN Editor has created an event where Registration is required
AND they click the checkbox for "Include information on how to join this event"
WHEN they choose the Call to action 'Register'
AND they click the checkbox for Registration is required for this event
AND they enter/choose all other required fields/information and Save
THEN the FE for the event displays the text "Registration: Required
AND the FE for the event displays "Register" as a link next to the green arrow

AC2: Editor chooses Call to Action 'Reserve your spot', and indicates RSVP is required

GIVEN Editor has created an event where an RSVP is required
AND they click the checkbox for "Include information on how to join this event"
WHEN they choose the Call to action 'Reserve your spot'
AND they click the checkbox indicating RSVP is required for this event
AND they enter/choose all other required fields/information and Save
THEN the FE for the event displays the text "RSVP: Required
AND the FE for the event displays "RSVP" as a link next to the green arrow

AC3: Editor chooses Call to Action 'Apply', and indicates this action is required

GIVEN Editor has created an event where submitting an application is required
AND they click the checkbox for "Include information on how to join this event"
WHEN they choose the Call to action 'Apply'
AND they click the checkbox indicating applying is required for this event
AND they enter/choose all other required fields/information and Save
THEN the FE for the event displays the text "Apply: Required
AND the FE for the event displays "Apply" as a link next to the green arrow

@jilladams
Copy link
Contributor

@timcosgrove do you have the time for this? Should this go to PW to manage as part of our ramp up on AP? (cc @FranECross @randimays )

@jilladams
Copy link
Contributor

@jilladams jilladams added VA.gov frontend CMS team practice area Public Websites Scrum team in the Sitewide crew labels Apr 8, 2024
@jilladams
Copy link
Contributor

Adding Public Websites team label since Tim agreed we could pick this up. Not removing AP, for visibility. (cc @FranECross )

@FranECross FranECross added the Blocked Issues that are blocked on factors other than blocking issues. label Apr 9, 2024
@mreed101
Copy link

mreed101 commented Sep 6, 2024

@timcosgrove @jilladams Any follow up on this?

@jilladams
Copy link
Contributor

We've been advised generally on Sitewide not to try and contribute code changes to AP just yet, while you all try to finalize Events to ship. If this is blocking, and we'd like to get Sitewide involved, let me know and I can follow up with @mmiddaugh / @Agile6MSkinner.

@jilladams jilladams added next-build FE Repository that will replace content-build. Uses NextJS, builds static pages. Events product maintained by Public Websites team and removed Blocked Issues that are blocked on factors other than blocking issues. labels Dec 23, 2024
@jilladams
Copy link
Contributor

Now that Events have launched, this is a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing Events product maintained by Public Websites team Needs refining Issue status next-build FE Repository that will replace content-build. Uses NextJS, builds static pages. Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants