Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal: Add VetCenter Banner Image to VetCenter Centralized Content #18709

Closed
3 tasks
Agile6MSkinner opened this issue Jul 22, 2024 · 13 comments
Closed
3 tasks
Assignees
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team

Comments

@Agile6MSkinner
Copy link

Agile6MSkinner commented Jul 22, 2024

Add VetCenter Banner Image to Drupal as Centralized Content

Description:

To support the differentiation of Vet Centers from VA Medical Centers, we need to add the approved VetCenter banner image to Drupal as centralized content. This will allow us to consistently use the image across all Vet Center facility pages.

Vet Center banner

vet-center-banner

Acceptance Criteria

  • 1. The VetCenter banner image is uploaded to Drupal's media library as embedded image
  • 2. Update vet center facility content type adding banner image from centralized content
  • 3. VetCenter banner image does not show on node edit or node view We will show this field, per comment.
@davidmpickett davidmpickett added Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Vet Center CMS managed product owned by Facilities team sitewide labels Jul 22, 2024
@Agile6MSkinner
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @davidmpickett @dsasser @omahane @jv-agile6

@aklausmeier
Copy link

aklausmeier commented Jul 24, 2024

@Agile6MSkinner This work is blocked may be further informed by design revisions in #18389

@davidmpickett
Copy link
Contributor

@aklausmeier I thought we agreed we weren't waiting for additional stakeholder feedback before moving forward with shipping small improvements to Vet Centers.

In story mapping earlier this week @Agile6MSkinner made a product call to go forward with the logo in order to start delivering value rather than trying to do the image exploration

@aklausmeier
Copy link

stakeholder has requested we explore an alternative image solution over a logo, also stated in design revision ticket, likely there will be an image here but it's not confirmed what it will be

@davidmpickett
Copy link
Contributor

@Agile6MSkinner @jv-agile6 @jilladams @mmiddaugh - I would recommend pulling this ticket out of sprint and marking as blocked

I just got out of a meeting with Amanda and Jordan. @aklausmeier emphasized that the stakeholders were have not approved moving forward with the logo. They want to first explore the image approach and only use the logo if that is untenable.

If we go with the image route, it's possible that this ticket would be unchanged aside from it being one national image rather than a one national logo, but there's also the possibility that we might need to support images specified at regional / local level.

@omahane
Copy link
Contributor

omahane commented Jul 24, 2024

@davidmpickett

but there's also the possibility that we might need to support images specified at regional / local level.

Does that mean an image for the main Vet Center that would pertain to it and other facilities?

@jilladams
Copy link
Contributor

Making the sprint change, so we don't churn.

@jilladams jilladams added the Blocked Issues that are blocked on factors other than blocking issues. label Jul 24, 2024
@jilladams
Copy link
Contributor

@Agile6MSkinner Agile6MSkinner changed the title Add VetCenter Logo to VetCenter Centralized Content Add VetCenter Banner Image to VetCenter Centralized Content Aug 5, 2024
@Agile6MSkinner
Copy link
Author

@thejordanwood Please add the image to this story.

@jilladams jilladams removed the Blocked Issues that are blocked on factors other than blocking issues. label Aug 7, 2024
@omahane
Copy link
Contributor

omahane commented Aug 16, 2024

@jilladams @davidmpickett @Agile6MSkinner @mmiddaugh I looked at this last night. I believe, there's no way through the UI to populate the default content without showing the field on node:edit (at least). I'm wondering what the reasoning is behind not showing the image, as we try to mirror the FE as much as possible normally. In any case, unless we want to write custom code, we'll need to show the image to editors.

Were we to show them on node:view and node:edit, the fields would still be locked down like the other centralized content fields.

@aklausmeier
Copy link

Since it's not editable, I would advocate for showing it to mirror FE but not sure if there was reasoning behind the AC that I'm not aware of.

VetCenter banner image does not show on node edit or node view

@omahane
Copy link
Contributor

omahane commented Aug 16, 2024

Decision on AC about hiding the field on node:view and node:edit

Per conversation in Slack, we will show this field as uneditable. I will edit the ACs.

@jilladams jilladams changed the title Add VetCenter Banner Image to VetCenter Centralized Content Drupal: Add VetCenter Banner Image to VetCenter Centralized Content Aug 16, 2024
@omahane
Copy link
Contributor

omahane commented Aug 21, 2024

Confirmed that this is visible on prod:
Screenshot 2024-08-21 at 9 49 22 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

7 participants