Recurring Events "Ends" dropdown exists on the page at -1,000px

[srancour]

Statuses

[2025-01-9] [Fran] Since this is a defect, and we still own Events, we have refined it

Describe the defect

In Drupal, when an event is made to be recurring there is a dropdown for "Ends" after the "Repeat every" "Repeat" type dropdown in the DOM. On the page, the "Ends" dropdown sits at -1,000px due to a left: -1,000px; on the .form-item--field-datetime-range-timezone-0-repeat-endcss class. This makes it so anyone on a screen smaller than 2915px can't see it, but it still exists and can be tabbed to with keyboard and a screen reader user still encounters it.

To Reproduce

Steps to reproduce the behavior:

1. Edit an event that's recurring like Music Therapy Jam Session
2. Tab though options after "Repeat every" input and dropdown
3. Either see focus onto "Ends" dropdown if screen size is at least 2915px wide, or see focus move onto nothing and then back on second tab.

Notes 2025-01-09

• See this comment below: Recurring Events "Ends" dropdown exists on the page at -1,000px #19162 (comment)

AC / Expected behavior

• The value for Ends should be permanently set to On Date
• When "Make recurring" is selected on the event form, the Ends field should not be readable by screen readers or visible on screen

Screenshots

Additional context

This seems to have been here for 2 years since the Recurring Events feature was completed at pull #7981. It looks like it came from a request to 'Remove "Never/After/On date" dropdown' in a comment on #7037 by @kevwalsh from 2021.

Desktop (please complete the following information if relevant, or delete)

• Window width of at least 2915px to visually see dropdown

[jilladams]

@laflannery despite not knowing the destiny of Events and whether we'll update them and when / where: Steve found an a11y issue, if you would like to put a defect level on it.

[laflannery]

@EWashb and @jilladams This is a regression I believe - This was resolved 2 years ago (almost to the day weirdly enough)

My best guess is that it might have had to do with the recent upgrade?

[srancour]

@laflannery if you look at the class in the code, it hasn’t changed since June of 2024 when the #7981 push happened. I also found this on prod on Friday before the update to Drupal went to prod, so I don’t think it had to do with this Drupal update. From what I could find in the linking tickets, there was that similar issue where the “All Day” checkbox was also at -1,000px, but I couldn’t find this as a bug previously found or fixed.

[jilladams]

I got a little lost in the link sauce there, but stepping through it:

• Date and Time component in the CMS has a visually hidden All Day checkbox field #10131 was filed and closed as resolved by "All Day" event checkbox is off screen rather than hidden when creating a VAMC event #10324
• "All Day" event checkbox is off screen rather than hidden when creating a VAMC event #10324 had one PR for a change that just removed a style on the All Day checkbox label: https://github.com/department-of-veterans-affairs/va.gov-cms/pull/10669/files. That change resulted in the All Day checkbox being dispay:none rather than pushed 1000px offscreen to the left, but Christia's PR does still show it in the DOM.
  • Steve Wirt did ask: why not remove it from the form in docroot/modules/custom/va_gov_events/src/EventSubscriber/EntityEventSubscriber.php : alterEventNodeForm()
  • Christia noted: the All Day field is added by Javascript, so can't be removed by form alter.

I'm not finding a comment anywhere that we were able to verify the fix on #10131, so it was prob lost in the shuffle of no Steve response.

If / when we pick this up, we will want to think through how we might be able to modify the JS to remove the All Day field as well (rather than display: none / having it present in the dom) as well as the "Ends" field, based on that PR / comments.

[FranECross]

@laflannery @randimays Do you know if this is this still an issue with NextBuild Events, or can be closed as a no-op? Thanks.

[randimays]

@FranECross This is an issue with editing events in the CMS (which is not affected by next-build), so we will still need to tackle this. Added the Drupal label to this ticket for clarity.

[FranECross]

@jilladams I updated the AC and added a Notes section with today's date on it, based on your comment above. Will you review and see if the AC is correct based on your understanding? Thanks!

[jilladams]

Took a look and updated the AC. Thanks!

[jilladams]

Moving back to Ready to Deploy since CMS is not regularly deploying at the mo.