Sitewide apps in vets-website must be able to deploy independently

[jilladams]

Description

The Platform Reliability Team will be rolling out changes to the front end deployment pipeline for vets-website on 2/3/25. Slack announcement

If an application's code is not isolated, teams will not be able to deploy the application to production without Platform assistance.

In #19780 we determined which applications will need modification for this change, and need to make & test those changes before the deadline.

#20043 Tracks facility widget / locator changes. This ticket is for the remaining apps.

Scope

App	path	Dependencies outside the Platform folder	Testing notes
Sitewide Announcements No updates needed	src/platform/site-wide/announcements	Widget type object might need to move to the platform folder Update: no imports outside of its own folder	We need to think about how to test this, since Announcements are very very rare, but I think are just vets-api driven. Product docs
TeamSites Helpers No updates needed	src/platform/site-wide/helpers/team-sites	Bucket object might need to move to the platform folder Update: this has one in the src/site folder that does not need to be updated (Slack thread).	Don't think we know what this app is / does, so during implementation we need to document that and work out how/what to test.
Side Nav	src/platform/site-wide/side-nav	Widget type object might need to move to the platform folder	This shows up everywhere. VAMCs and Resources & Support have has the most elaborate implementation. We'll need eng notes on what changes are required for this, to determine test needs. Engineering notes: This is only used for Facilities pages with a side bar using data-widget-type="side-nav" (for example: https://va.gov/greater-los-angeles-health-care/locations/los-angeles-va-clinic/)

Apps will not actually begin deploying independently until Platform starts cutting them over to CI/CD in Feb. We'll cover support / testing during that window under #20047.

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

• Functional testing:
• Code review:
• Design review: - N/A, this is only an under the hood change and will not modify markup or FE build. (Should not.)
• Accessibility review: - N/A, this is only an under the hood change and will not modify markup or FE build. (Should not.)
• Product acceptance: Michael

Acceptance criteria

• Side nav app can be built with only dependencies in the Platform folder
• Behavior and appearance of left nav does not change, remains the same as Prod on:
  • Resources & support pages
  • VAMC System pages
  • Manila
  • Lovell
• Sitewide Announcements app can be built with only dependencies in the Platform folder
• Behavior and appearance of the Sitewide Announcements app does not change, remains the same as Prod, after any functions are moved to the platform folder
• TeamSites Helpers app can be built with only dependencies in the Platform folder
• Behavior and appearance of TeamSites Helpers does not change, remains the same as Prod <we have no idea what this means right now>
• DO NOT MERGE UNTIL WE DETERMINE EXTENT OF TESTING

[randimays]

Update: The scope of this ticket is smaller than we originally anticipated:

src/platform/site-wide/announcements: This application does not have any imports outside of its own folder and won't need any changes.

src/platform/site-wide/helpers/team-sites: This set of utilities imports from the src/site folder, but per Platform, the src/platform and src/site folders will remain as-is and ship together. Any imports between the two folders do not need to be changed at this time. Slack thread

src/platform/site-wide/side-nav: As anticipated, this one does have an import from the src/applications folder and will need an update to move the widgetTypes definition, which does affect some other applications.

Updating ACs & description accordingly.

[randimays]

Code has been deployed and apps are working as expected in production. Closing as complete.