Banners endpoint does not respond as expected for certain banner values

[timcosgrove]

What is the problem?

When a VAMC real time banners is implemented with certain active paths, the Banners API endpoint does not return data correctly.

When a Full Width Banner is implemented with certain active paths, the Banners API endpoint does not return data return correctly.

Who is affected?

End users, as banners may be prevented from showing up on the site.

How urgent is the issue?

Critical / Major / Minor
Major

Tasks

Preview Give feedback

1. The problem as described is fixed
2. The repro steps result in 'expected result'
3. An automated test is written to catch the problem, if appropriate

How can we see the problem? (repro steps)

1. Set up a VAMC Banner with situation update on a given Drupal instance. Make sure the banner is published, and that it has the following values for path matching: /, /*
2. Visit the banners API endpoint on this same Drupal instance, with the following path: /api/v1/banner-alerts?path=/pittsburgh-health-care/events

Expected result: Data should be returned that contains the banner created in 1.

Actual result: The data is empty.

Is there any additional information?

Interestingly, /pittsburgh-health-care/events/ works fine.

Why is the problem happening and how do we fix it?

[jilladams]

@timcosgrove We ran into confusion when trying to refine this ticket for action. Context:

1. Full width banners proper don't use the banners API. Right now, only VAMC Banner Alerts with Situation Updates are handled through that API.
2. VAMC BAwSUs don't use regex path definition to determine what pages they should show on. They use a checklist that gives the option of selecting any VAMC System, which will show the banner on every VAMC system page, OR only the landing page / operating status page of the System.

Given that you're talking about the banners API, that implies we are not dealing with "full width banners" on Events pages, but actually dealing with "VAMC Banner Alert with Situation Updates". I updated that in ticket body, but that may be incorrect?

I did not update the reference to path definition of /* or /. However: that does not apply to VAMC BAwSUs.

So: in order to work the ticket, we need to figure out:

• Which content type was not appearing correctly? Was it:
  • A) Full width banners that are configured via / or /* to appear on VAMC Event pages, (and are built via content-build on every other page) OR
  • B) VAMC BAwSUs (aka real-time banners now), which rely on the banners API and are now a vets-website application
• If it was A, why do we think the banners API is implicated?

[jilladams]

Per a slack convo with Tim:
This is not about realtime banners and is only a problem for 'Full Width Banners', not for the Facility situation updates.

This is not about the real-time banners API in vets-api; it's about the banners API in the CMS
There's a JSON:API endpoint that provides banners data to Next Build. That's what this ticket was about.

This came up when Michelle was publishing the banner for the shutdown, which was a Full Width Banner; and it wasn't showing up correctly for Events because of a Next Build internal problem.

I'm removing this from the real-time banners epic / the SItewide board. Thanks for clarifying, Tim!