Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tabs to segmented button group #20153

Open
8 tasks
thejordanwood opened this issue Dec 20, 2024 · 0 comments
Open
8 tasks

Change tabs to segmented button group #20153

thejordanwood opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team sitewide VA.gov frontend CMS team practice area

Comments

@thejordanwood
Copy link

thejordanwood commented Dec 20, 2024

Description

The View list and View map tabs currently on mobile aren't recommended by the Design System Team. At a Design System Council meeting on 1/16/2025, we brought an experimental design ticket to them asking if we can use the USWDS segmented button group. It was decided that we would use the segmented button group the mobile app uses and test this styling during usability testing. If this tests well, our team can contribute it back to the design system and make it an official component.

Design

Facility Locator Figma file

Current (tabs)

Image

Updated (segmented button group)

Image

Engineering Notes

QA / Testing

  • Design review
  • Accessibility review

Acceptance criteria

  • Feature work is placed behind a feature toggle to be viewed in Staging only, while preserving Production behavior: facility_locator_mobile_map_update
  • Mapbox always needs to be in the DOM whether displayed or not. Button select determines if it is displayed.
  • New segmented button component take the place of the tabs
  • When switching between list and map, the search parameters persist
  • When changing search parameters, both list and map update
  • Design matches Figma file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

5 participants