Restore original Facility Locator behavior pre-progressive disclosure work & create a feature toggle

[jilladams]

Description

When we built the original changes for Progressive Disclosure, we were not originally planning to block shipping it on research. In that process, we removed / revised the behavior of the production Facility Locator code.

Now that we will research before shipping, we must allow Progressive Disclosure to exist in code alongside the existing Production behavior. AKA: we need to put some stuff back that we ripped out.

We also need to be able to toggle from the existing Prod behavior, to the new progressive disclosure behavior, in Staging. This requires creating a vets-api feature toggle, and updating the vets-website application to be able to toggle the filter state based on the toggle.

Technical notes

1. This needs testing to verify in a Tugboat with feature toggle on and off before merging.
2. With toggle off: we need to fully re-verify the Facility Locator behavior from prod to ensure that ripping out > putting back didn't break anything unexpected, since we don't know how long this will all be in place. (At minimum: til research is done, any findings are addressed, and we are able to ship Progressive Disclosure, which could get tangled in contract boundary.)

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

• Functional testing:
• Code review:
• Design review:
• Accessibility review:
• Product acceptance:

Acceptance criteria

• A feature toggle is created in vets-api
  • When feature toggle is on: Progressive Disclosure changes display
  • When feature toggle is off: existing prod behavior (disabled Services filter) displays
• Production behavior of the Facility Locator prior to Prog Disclosure is verified with no regressions

[Agile6MSkinner]

Progressive disclosure and service autosuggest will be researched together. Does that change the ACs here?

[eselkin]

We can include both behind a feature toggle/flipper or just make 2 and then remove them both after testing provided both pass appropriately.

We probably need to copy the changed styles to a new named class or id (like adding -new to the class or id). Then use the new class/id for the updated components and make the old ones use the original name.

So it's a matter of keeping everything in order, just annoying but 3 points should cover it.