fix(nextjs-sdk): add support for NextJS 15 #885
Conversation
allenzhou101
requested review from
asafshen and
nirgur
and removed request for
asafshen
| // from Next.js 15, headers() returns a Promise | ||
| // It can still be used synchronously to facilitate migration | ||
| const reqHeaders = headers() as never as HeaderTypes; | ||
| export const session = async (): Promise<AuthenticationInfo | undefined> => { |
There was a problem hiding this comment.
Think break BC
Also for someone that is not using next 15
Let's think about how to achieve that breaking
There was a problem hiding this comment.
Seems to maintain backwards compatibility and access the session synchronously server-side, we would need to switch off of headers, cookies, or any other API from NextJS that is now asynchronous. So doing the same thing where we set the session into whatever storage mechanism (like how it's headers right now) in middleware and accessing via session function.
Options are:
- File-Based Storage (https://www.npmjs.com/package/@types/better-sqlite3)
- Different cookie library that's synchronous (https://www.npmjs.com/package/cookie)
Thoughts on this? At some point we'll probably have to bite the bullet and make the session call async, but maybe once NextJS fully moves off?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 017a3d7.
☁️ Nx Cloud last updated this comment at |
Related Issues
Fixes #884
Description
Migrates the SDK to NextJS 15
Must