cron_dailyupdate.sh broken with desitree 0.6.0 due to missing $DESI_ROOT

[sbailey]

etc/cron_dailyupdate.sh uses

    module use /global/common/software/desi/$NERSC_HOST/desiconda/startup/modulefiles
    module load desimodules/main

instead of sourcing desi_environment.sh main. This broke with the desimodules/main update to desitree/0.6.0 on Friday 2022-08-19 because now $DESI_ROOT is set in desi_environment.sh rather than in desitree. I think that was because on Perlmutter with lmod, there was some issue with propagating $DESI_ROOT set in one module file into another.

I'm not sure if cron_dailyupdate.sh was avoiding desi_environment.sh for a specific technical reason, or perhaps just because module use + module load seemed more explicit about what it was doing (most of the logic in desi_environment.sh is handling special cases to work across multiple machines, including dtn).

Investigate and test whether cron_dailyupdate.sh could use desi_environment.sh. In the meantime daily updates + tests aren't running.

[weaverba137]

Original context for all of this: desihub/desitree#6.

[weaverba137]

@sbailey, this has to have been fixed by now, right?