Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove moon calcs from database tutorial #106

Open
sbailey opened this issue Jan 29, 2025 · 0 comments
Open

remove moon calcs from database tutorial #106

sbailey opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@sbailey
Copy link
Collaborator

sbailey commented Jan 29, 2025

The spectroscopic-production-database.ipynb tutorial has some leftover code related to data quality vs. phase of the Moon. This was originally requested by me to have a tangible worked example, but at this point it is largely vestigial since it makes most sense in the context of per-exposure redshifts, which we never loaded into the DB anyway. I suggest that we remove that code, which will allow us to remove the desisurvey dependency and related things like setting $DESISURVEY_OUTPUT to a magic directory at NERSC, defining the "moon" function, etc. The rest of the tutorial which focuses on specific queries and mapping raw SQL into sqlalchemy operations is good, and removing the moon stuff will help focus the tutorial on the database itself rather than moon ephemeris details unrelated to the DB itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants