Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GPU tests also on MPS in PR template #210

Open
jank324 opened this issue Jul 4, 2024 · 2 comments
Open

Allow GPU tests also on MPS in PR template #210

jank324 opened this issue Jul 4, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jank324
Copy link
Member

jank324 commented Jul 4, 2024

It seems that (with a new enough version of PyTorch at least) Cheetah works with MPS now (related to #61). Should we (a) close #61 and (b) change to tick point on the PR template that requests running the tests on CUDA to also allow MPS.

This would basically mean that every Mac user is running tests on a GPU device by default. I think the main reason to run tests on GPU is to make sure that device moving and matching works.

@jank324 jank324 added the documentation Improvements or additions to documentation label Jul 4, 2024
@cr-xu
Copy link
Member

cr-xu commented Jul 16, 2024

Sure. We should add a CI/CD for m1 device and close #61.

Another question though: should we also allow this to run for also all python versions & push and PRs, at some points the CI/CD pipelines are just too excessive

@jank324
Copy link
Member Author

jank324 commented Jul 17, 2024

I think a "GPU" run on the newest version of Python is enough, at least until we run into version-specific issues. I would also like to remove Python 3.9 at some point (see #205), which would reduce the number of jobs. That's currently blocked by the DOOCS bindings only being available for 3.9 though.

@cr-xu cr-xu linked a pull request Jul 23, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants