Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BPM reading is not registered as a buffer #329

Open
Hespe opened this issue Jan 29, 2025 · 0 comments · May be fixed by #335
Open

BPM reading is not registered as a buffer #329

Hespe opened this issue Jan 29, 2025 · 0 comments · May be fixed by #335
Assignees
@Hespe
Labels
bug Something isn't working

Comments

@Hespe
Copy link
Member

Hespe commented Jan 29, 2025

The reading property of BPM is not registered as a buffer. This leads to problems when casting the BPM into another dtype or moving it to another device.

Similarly, Screen does not register its cached_reading.
@Hespe Hespe added the bug Something isn't working label Jan 29, 2025
@Hespe Hespe self-assigned this Feb 6, 2025
@Hespe Hespe linked a pull request Feb 6, 2025 that will close this issue
Open
14 tasks
@Hespe Hespe linked a pull request Feb 6, 2025 that will close this issue
Register element readings as torch buffers for proper dtype conversion #335
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hespe Hespe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Register element readings as torch buffers for proper dtype conversion desy-ml/cheetah
1 participant
@Hespe