Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup script should check return code of configure step #220

Open
bast opened this issue Dec 7, 2017 · 2 comments
Open

Setup script should check return code of configure step #220

bast opened this issue Dec 7, 2017 · 2 comments

Comments

@bast
Copy link
Member

bast commented Dec 7, 2017

Instead of doing this: https://github.com/coderefinery/autocmake/blob/master/autocmake/configure.py#L113-L118 which is brittle.

@miroi
Copy link
Contributor

miroi commented Jan 8, 2018

Hi Rado,

def save_setup_command(argv, build_path)

is very useful function, because ordinary software users sometimes forget what exact form of setup command did they use.

For example, in DIRAC "./setup --mpi --fc=mpif90 --cc=mpicc --cxx=mpiCC --int64 --extra-fc-flags=-xHost --extra-cc-flags=-xHost --extra-cxx-flags=-xHost build_openmpi_intelmkl_i8_xh"

The setup_command file is missing '' . Would be good to add apostrophe.

@bast
Copy link
Member Author

bast commented Jan 9, 2018

I think your suggestion is unrelated to the topic of this issue. Can you please open a new issue? Also in your issue please show what the command prints out now and what you would like to print instead. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants