Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only goes between online and champion select text #20

Open
josephisticated opened this issue Jul 25, 2024 · 13 comments
Open

Only goes between online and champion select text #20

josephisticated opened this issue Jul 25, 2024 · 13 comments

Comments

@josephisticated
Copy link

josephisticated commented Jul 25, 2024

Tried to change language, make client close while the game's running, only worked in training mode for once so far, couldn't replicate making it work in training mode.

sessionlog.json

@josephisticated josephisticated changed the title Gets stuck in champion select text Only goes between online and champion select text Jul 25, 2024
@developers192
Copy link
Owner

Can you tell me which language did you change to specifically?

@developers192
Copy link
Owner

Also, it only happened once, right? Can you post the sessionlog after it works again?

@developers192
Copy link
Owner

Nevermind. I was able to replicate the issue. A fix coming in about 1 or 2 days

@josephisticated
Copy link
Author

went between turkish and english (us), might i ask what was the issue? just curious 😄

@josephisticated
Copy link
Author

josephisticated commented Jul 26, 2024

Also, it only happened once, right? Can you post the sessionlog after it works again?

what happened once is that it only showed i was in a match once, which was a training mode match, always gets stuck in champion select now, by the way if ultimate skins had their animated splash art in the rich presence it could be pretty cool, don't know if their heads would sway out of the bounds though.

@developers192
Copy link
Owner

went between turkish and english (us), might i ask what was the issue? just curious 😄

It's just an API thing. Basically, in the latest release, I coded the program so that it would not update the presence if the lobby was not found, which was causing issues previously. However, I forgot to add an edge case for custom matches.

@developers192
Copy link
Owner

ultimate skins had their animated splash art in the rich presence it could be pretty cool, don't know if their heads would sway out of the bounds though.

That would be pretty cool! I'll probably implement that. Since the number of ultimate skins aren't that many, I can manually crop out the images myself.

@developers192
Copy link
Owner

developers192 commented Jul 26, 2024

Should be fixed in the latest update. I also implemented animated splash arts. Thanks for reporting and suggesting!
Check out v3.2.0. Let me know if it works!

@josephisticated
Copy link
Author

Should be fixed in the latest update. I also implemented animated splash arts. Thanks for reporting and suggesting! Check out v3.2.0. Let me know if it works!

Works wonderfully, just tried it with DJ Sona. A tiny detail though, I think it can play the video provided around 6 seconds which shows Sona's only first form. Don't know if it's a pre-set thing or something with webm file format but if I remember correctly, Discord rich presence could play a gif around for a minute or more, tried to play the whole shrek movie on my rich presence but it cut around where it showed the swamp.

@josephisticated
Copy link
Author

Oh and because this app disables league's own rich presence I am not able to use the dedicated rich presence invite system, there being a setting to turn it on or having both of the presences until invite system is added would be nice because currently I need to close the app to use it.

@developers192
Copy link
Owner

The original GIF of Sona is about 100MB, so when someone clicks on your profile, it would take minutes to load. Therefore, I had to cut it and apply a lot of compression to reduce it to a desirable size, especially since no one would look at your profile for that long. If they want to watch the whole thing, they should just click view splash instead.

Regarding the invite system, I am still trying to implement it. I have to use another computer to test it. Also, League's native rich presence would override the whole thing, so running both at the same time is not possible.

@josephisticated
Copy link
Author

since a couple months ago, discord allows multiple rich presences to run at the same time, i don't know which gets to be shown mainly but it can be, btw i used it that way with detailedlolrpc too actually, dlolrpc gave an error on startup and both of the rich presences run smoothly

@developers192
Copy link
Owner

It does allow multiple presences, but we can't control which one gets shown mainly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants