Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Req]: HTML5 Minifier #8

Open
dlford opened this issue Sep 14, 2022 · 5 comments
Open

[Req]: HTML5 Minifier #8

dlford opened this issue Sep 14, 2022 · 5 comments
Labels
exploring Deciding how best to solve this feature request New feature or request

Comments

@dlford
Copy link
Member

dlford commented Sep 14, 2022

Contact Details

No response

Explain the proposed feature

Add minifier to HTML format tool

Explain the possible use cases for the feature

No response

Any other details you would like to provide?

No response

Notes

  1. HTML Format is completed HTML Format #18
  2. We'll have to get creative with the minify part, because most of the NPM packages won't run in browser
  3. Suggestions from @ageddesi:
@dlford dlford added help wanted Anyone can pick this up and start working on it feature request New feature or request labels Sep 14, 2022
@dlford dlford added the hacktoberfest This is a valid Hacktoberfest issue label Oct 3, 2022
@dlford dlford mentioned this issue Oct 4, 2022
2 tasks
@dlford dlford linked a pull request Oct 4, 2022 that will close this issue
2 tasks
@dlford dlford removed a link to a pull request Oct 4, 2022
2 tasks
@dlford dlford changed the title [Req]: HTML5 Format / Minify [Req]: HTML5 Minifier Oct 8, 2022
@dlford
Copy link
Member Author

dlford commented Oct 8, 2022

@ageddesi thanks for the suggestions! Did you want to take a crack at this?

@ageddesi
Copy link

ageddesi commented Oct 8, 2022

Could be fun. Will try look over next few days. :)

@dlford
Copy link
Member Author

dlford commented Oct 8, 2022

Could be fun. Will try look over next few days. :)

Awesome! Much appreciated!

@dlford dlford removed the help wanted Anyone can pick this up and start working on it label Oct 8, 2022
@ageddesi
Copy link

ageddesi commented Oct 8, 2022

So far I am hitting 'Module not found: Can't resolve 'fs'' issues with the package I am using
https://github.com/terser/html-minifier-terser
Will need to have another look tomorrow

@dlford
Copy link
Member Author

dlford commented Oct 8, 2022

So far I am hitting 'Module not found: Can't resolve 'fs'' issues with the package I am using https://github.com/terser/html-minifier-terser Will need to have another look tomorrow

Yeah, that's the issue, most of the minifiers are for node, thanks for looking into it for me though!

@dlford dlford added exploring Deciding how best to solve this and removed hacktoberfest This is a valid Hacktoberfest issue labels Oct 19, 2022
@dlford dlford added hacktoberfest This is a valid Hacktoberfest issue and removed hacktoberfest This is a valid Hacktoberfest issue labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exploring Deciding how best to solve this feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants