Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename altL to orElse and accept failure in callback #5

Open
raveclassic opened this issue May 21, 2018 · 1 comment
Open

Rename altL to orElse and accept failure in callback #5

raveclassic opened this issue May 21, 2018 · 1 comment
Labels
breaking change improvement New feature or request

Comments

@raveclassic
Copy link
Contributor

  • to be more aligned with fp-ts
@raveclassic raveclassic added improvement New feature or request breaking change labels May 21, 2018
@raveclassic raveclassic mentioned this issue Oct 24, 2018
Merged
@sutarmin
Copy link

Did I get it right that altL is calling its callback for all RemoteData "states" except RemoteSuccess but orElse should call its callback only when RD is RemoteFailure state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raveclassic @sutarmin