Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use :binary.split for Erlang example #28

Open
codeadict opened this issue Feb 25, 2022 · 0 comments
Open

Use :binary.split for Erlang example #28

codeadict opened this issue Feb 25, 2022 · 0 comments

Comments

@codeadict
Copy link

codeadict commented Feb 25, 2022

The example here https://github.com/devonestes/fast-elixir/blob/master/code/general/string_split_large_strings.exs#L21 uses Erlang's string module but this is not a fair comparison since Elixir strings are binaries. Maybe this should have a test with https://www.erlang.org/doc/man/binary.html#split-3:

binary:split(Str, <<",">>, [global]).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant