Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from / patch version of pkcs11 #367

Open
5225225 opened this issue Jul 16, 2022 · 3 comments
Open

Migrate away from / patch version of pkcs11 #367

5225225 opened this issue Jul 16, 2022 · 3 comments

Comments

@5225225
Copy link

5225225 commented Jul 16, 2022

In rust-lang/rust#98839 a check for transmute_copy's precondition that T is not smaller than U was added. A crater run was done, which did affect pkcs11, but I didn't think to check reverse dependencies. This seems to be the only major crate that uses it?

I made an issue (mheese/rust-pkcs11#55) and later a PR (mheese/rust-pkcs11#56) to fix it, but the project's not seen activity in 2 years, so odds of it getting fixed is slim. And judging from the issue list, the crate has a fair amount of other problems with it.

Not all APIs are affected, but some are.

I also made an issue for a rustsec advisory, but seeing as I don't know the crate too well, and there's more than a few issues, I didn't write it up.

@ionut-arm
Copy link

Hello!

We've been trying to create a replacement for pkcs11 in cryptoki because of the security issues we found while using it, and because the maintainer of that crate seems to have abandoned it. cryptoki is essentially a fork of pkcs11 in which we've tried to fix the problems related to memory handling. Unfortunately we don't have too much spare bandwidth to continue development in a sustained way, but we're happy to get contributions from the community. Hope this helps.

@sesi200
Copy link
Contributor

sesi200 commented Jul 21, 2022

Hi guys, thank you very much for notifying us! @krpeacock is looking into it together with our security team.

@ionut-arm
Copy link

If you do find any (security) issues with the crate please feed that back 🙏🏻 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants