Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure maxTimeToLive is bigint and not number #1050

Open
nmattia opened this issue Nov 24, 2022 · 0 comments
Open

Ensure maxTimeToLive is bigint and not number #1050

nmattia opened this issue Nov 24, 2022 · 0 comments

Comments

@nmattia
Copy link
Collaborator

nmattia commented Nov 24, 2022 •
edited
Loading

It looks like some clients (in particular taggr) use a number maxTimeToLive in the authentication request, whereas Internet Identity expects a bigint.

For now we'll be lenient and accept bigint as well as number but we should ensure all our client libraries enforce bigint.

Note: as we make the interface more strict again we should add a test suite.
nmattia added a commit that referenced this issue Nov 24, 2022
@nmattia
Accept number maxTimeToLive
095e40a 
This makes our postMesasge interface a bit more lenient (see #1050 for details) and adds console logs to ease debugging of bad authentication requests.
@nmattia nmattia mentioned this issue Nov 24, 2022
Merged
nmattia added a commit that referenced this issue Nov 24, 2022
@nmattia
Accept number maxTimeToLive (#1051)
957b04a 
This makes our postMesasge interface a bit more lenient (see #1050 for details) and adds console logs to ease debugging of bad authentication requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmattia