Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v2 note update #721

Open
8 tasks done
c8y3 opened this issue Feb 14, 2025 · 2 comments · Fixed by #732
Open
8 tasks done

API v2 note update #721

c8y3 opened this issue Feb 14, 2025 · 2 comments · Fixed by #732
Assignees
Labels
enhancement New feature or request

Comments

@c8y3
Copy link
Contributor

c8y3 commented Feb 14, 2025

Implement endpoint PUT /api/v2/cases/{case_identifier}/notes/{identifier} to update a note.

  • return 200 in case of success
  • if the object is not found, return 404
  • if the case is not found, return 404
  • create method in business layer
  • check returned object is uniform with other endpoints
  • deprecate POST /case/notes/update/{note_id}
  • openapi: document endpoint
  • openapi: deprecate POST /case/notes/update/{note_id}
@c8y3 c8y3 added the enhancement New feature or request label Feb 14, 2025
@c8y3 c8y3 self-assigned this Feb 14, 2025
@c8y3
Copy link
Contributor Author

c8y3 commented Feb 28, 2025

  • modify note_title
  • return 400 when note_title is a string
  • return 400 when directory_id does not belong to an existing directory

@c8y3
Copy link
Contributor Author

c8y3 commented Feb 28, 2025

  • Fixed+test: PUT /api/v2/cases/{case_identifier}/iocs/{identifier} should return 404 when case_identifier does not correspond to any existing case
  • Set up the redoc linter on the openapi documentation
  • Fixed some warning of the redoc linter, many are still remaining. For now, they are ignored. Will fix gradually.

@c8y3 c8y3 linked a pull request Feb 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant