forked from gadget-framework/gadget3
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathcran-comments
232 lines (137 loc) · 7.05 KB
/
cran-comments
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
# https://cran.r-project.org/submit.html
==== 0.12-1
Additional release to fix CRAN-pretest problems.
> Flavor: r-devel-linux-x86_64-debian-gcc
> Check: Rd cross-references, Result: NOTE
> Found the following Rd file(s) with Rd \link{} targets missing package
> anchors:
> run_tmb.Rd: MakeADFun
> Please provide package anchors for all Rd \link{} targets not in the
> package itself and the base packages.
Fixed with https://github.com/gadget-framework/gadget3/commit/dc6e9aa24c6e655820156d7b9e583b367c558369
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/blob/v0.12-1/NEWS.md
https://github.com/gadget-framework/gadget3/compare/v0.12-0...v0.12-1
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/9773508008
==== 0.12-0
New release of existing package.
> Please see the problems shown on
> <https://cran.r-project.org/web/checks/check_results_gadget3.html>.
>
> Please correct before 2024-07-12 to safely retain your package on CRAN.
The "donttest" CRAN test failure was caused by an example triggering a bug in TMB.
This is now fixed in TMB 1.9.13, and gadget3 tests are already passing.
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/blob/v0.12-0/NEWS.md
https://github.com/gadget-framework/gadget3/compare/v0.11-1...v0.12-0
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/9765012824
==== 0.11-1
Bugfix release to fix pretest NOTE:
> Found the following (possibly) invalid file URI:
> URI: /reference/index.html
> From: inst/doc/introduction-single-stock.html
/reference/index.html is the pkgdown reference index, which obviously does not
exist on CRAN. This has been fixed with the following commit:
https://github.com/gadget-framework/gadget3/commit/d5bb93eafd06b1277695081d2f7e7d953233435e
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/blob/v0.11-1/NEWS.md
https://github.com/gadget-framework/gadget3/compare/v0.11-0...v0.11-1
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/8342609870
==== 0.11-0
New release of existing package.
> Error in seq_call$by > 0 :
> comparison (>) is not possible for language types
This has been fixed with the following commit:
https://github.com/gadget-framework/gadget3/commit/ee6c7a59c2594044f94a0dc6aa9e109290ba56b4
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/blob/v0.11-0/NEWS.md
https://github.com/gadget-framework/gadget3/compare/v0.10-1...v0.11-0
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/8340526551
==== 0.10-1
New release to fix CRAN-pretest problems.
Examples no not finish under Windows with --run-donttest, this appears to be a
bug in TMB:
https://github.com/kaskr/adcomp/issues/385
The relevant example has been disabled under Windows as a workaround:
https://github.com/gadget-framework/gadget3/commit/f42f9dda644aba2d2e3ecee5b470c6b7a17a65cc
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/blob/v0.10-1/NEWS.md
https://github.com/gadget-framework/gadget3/compare/v0.10-0...v0.10-1
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/5961520352
==== 0.10-0
New release of existing package.
Test failure: donttest:
> Running examples in ‘gadget3-Ex.R’ failed
> > writeLines(TMB::gdbsource(g3_tmb_adfun(cpp, compile_flags = "-g", output_script = TRUE)))
> Error in system(cmd, intern = TRUE, ignore.stdout = FALSE, ignore.stderr = TRUE) :
> error in running command
> Calls: writeLines -> <Anonymous> -> system
> Execution halted
TMB::gdbsource() expects both `R` and `gdb` to be available on the path, the
example is now wrapped with a test to make sure this is the case before running:
https://github.com/gadget-framework/gadget3/commit/f84f816ded28101461cddda703519c3f8df3f3cf
R-pkg-devel discussion on issue:
https://stat.ethz.ch/pipermail/r-package-devel/2023q3/009428.html
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/blob/v0.10-0/NEWS.md
https://github.com/gadget-framework/gadget3/compare/v0.9-0...v0.10-0
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/5923993347
==== 0.9-0
New release of existing package.
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/blob/v0.9-0/NEWS.md
https://github.com/gadget-framework/gadget3/compare/v0.8-4...v0.9-0
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/5014802650
==== 0.8-4
Resubmission of new package after comments from CRAN team:
> Missing Rd-tags:
> step.Rd: \value
Section added.
> Missing Rd-tags:
> aab_env.Rd: \value
aab_env documents an environment, not a function. \usage removed instead of adding \value.
> Examples for unexported function
> lgamma_vec() in:
> action_grow.Rd
> action_migrate.Rd
> action_naturalmortality.Rd
> . . .
lgamma_vec() does not appear in any of the listed examples. However, based on the listed examples the test is objecting to occurences of '~g3_param(...)'.
These examples have been reworked to remove this.
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/compare/v0.8-3...v0.8-4
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/3572975479
==== 0.8-3
Resubmission of new package after comments from CRAN team:
> Please always write package names, software names and API (application programming interface) names in single quotes in title and description. e.g: --> 'R','C++'
Done.
> Please add the references to your description (i.e. in DESCRIPTION) text
Added references to the 'Description' field
> You have examples for unexported functions.
* Removed gadget3:::step_find_desc() from vignettes
* gadget3:::stock_instance Now public, as g3_stock_instance
* gadget3:::g3_native now public
* gadget3:::g3_global_formula now public
* gadget3:::g3_step now public
> Please ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace (including the package directory and getwd())
g3_tmb_adfun() defaults to 'work_dir = tempdir()', so agreed that explicit 'work_dir = tempdir()' in examples shouldn't be necessary.
Differences since the previous submission:
https://github.com/gadget-framework/gadget3/compare/v0.8-2...v0.8-3
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/3539714763
==== 0.8-2
New submission for the Gadget3 model framework.
The source to build the package can be found here, along with the README:
https://github.com/gadget-framework/gadget3/tree/v0.8-2
Built documentation can be found here:
http://gadget-framework.github.io/gadget3/
CI test reports can be found here:
https://github.com/gadget-framework/gadget3/actions/runs/3487382666