-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Holidays #3
Comments
Do you have more detailed specs in mind for this feature ? |
@msuret Hey. Thanks for the followup. So we have started to work on this. Use case is that a business hours schedule is valid "except" for "holidays". So a holiday list support would be very helpful. We started looking at ways to extend the library to support more of the Time::Period Perl module standard and looking at a way to add a specific date support. such as Dec 25 and Jan is a holiday. |
I try to implement it by adding new fields in SUPPORTED_FIELD (https://github.com/GuillaumeSmaha/business-hours-java/blob/feature/add_support_month_year/src/main/java/org/dhatim/businesshours/BusinessHoursParser.java#L56) Also, I was blocked to insert month and year due to the calculation of duration (year and month can have different values in seconds). |
@GuillaumeSmaha Thanks, I'm a bit busy this week-end but I'll have a look asap ! |
No description provided.
The text was updated successfully, but these errors were encountered: