Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue Report]: SDL_RenderSetIntegerScale() is required but not avalible in SDL 2.0.3 #7534

Open
AJenbo opened this issue Nov 12, 2024 · 5 comments

Comments

@AJenbo
Copy link
Member

AJenbo commented Nov 12, 2024

Operating System

Mac PPC

DevilutionX version

1.5.3

Describe

We support SDL 2.0.3 but when trying to build you get an error regarding SDL_RenderSetIntegerScale() not being found.

To Reproduce

Find an old version of SDL2, try to compile

Expected Behavior

No response

Additional context

No response

@glebm
Copy link
Collaborator

glebm commented Nov 13, 2024

Ah, that function is only available since SDL 2.0.5, so we should guard against that
Or perhaps just say that we require 2.0.5+

@AJenbo
Copy link
Member Author

AJenbo commented Nov 15, 2024

I'm ok with either. We could just hide the interger scale option on older SDL. PPC Mac has SDL 1.2.15 and 2.0.3. And so fare it feels like the SDL 1.2 port works better (but since I have only tested DevilutionX 1.0.3 not many features where available).

We already turn it off when SDL1.2 is in use.

@AJenbo
Copy link
Member Author

AJenbo commented Nov 15, 2024

Looks like SDL_GetDisplayDPI and SDL_SetWindowResizable() are in a similar situation

@glebm
Copy link
Collaborator

glebm commented Nov 15, 2024

Let's see if the latest SDL2 works on 10.4 ppc mac with macports.
If that works, we can simply bump the requirement.

Might take a week to find out, things are very slow to build

@AJenbo
Copy link
Member Author

AJenbo commented Nov 16, 2024

The fact that if you click in the upper right corner you hit the OS search bar makes the SDL2 that is in tigerbrew really undesirable any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants